feat: add ExternalSort project documentation adhereing to canvas course project instructions #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Divy Patel <divy9881@gmail.com>
…se project instructions Signed-off-by: Divy Patel <divy9881@gmail.com>
…se project instructions Signed-off-by: Divy Patel <divy9881@gmail.com>
sahilnap06
reviewed
Dec 6, 2023
Collaborator
sahilnap06
left a comment
sahilnap06
left a comment
There was a problem hiding this comment.
One comment inline
Also they have asked us to mention the individual contribution in the README.
README.md
Outdated
| # Reasons we chose to implement the specific subset of techniques | ||
| # Project's state(complete or have what kinds of bugs) | ||
| # Reasons we chose to implement the specific subset of techniques | ||
| - `Tournament-tree priority queue` was used in order to achieve `high fan-in` for merging our sorted run inputs of records |
Collaborator
There was a problem hiding this comment.
we can add
"and less number of comparisons than a standard tree-of-winners" (We are using the tree of losers tournament tree)
…se project instructions Signed-off-by: Divy Patel <divy9881@gmail.com>
…se project instructions Signed-off-by: Divy Patel <divy9881@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.