Skip to content

FIx github issue titles #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 10, 2025
Merged

FIx github issue titles #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a6c791
Update the issue snapshot.
nedtwigg Oct 10, 2025
c2406bf
Update the issue extraction logic.
nedtwigg Oct 10, 2025
7d943b0
Update the snapshots.
nedtwigg Oct 10, 2025
9ee017b
Update changelog.
nedtwigg Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Version must be kept in-sync between [`package.json`](package.json) and [`wxt.co

## [Unreleased]
### Fixed
- GitHub issues were not scraping the correct title. ([#109](https://github.com/diffplug/gitcasso/issues/109))
- We don't show edited comments in the popup table anymore. ([#110](https://github.com/diffplug/gitcasso/pull/110))

## [1.1.0] - 2025-10-07
Expand Down
2 changes: 1 addition & 1 deletion src/lib/enhancers/github/GitHubIssueAppendEnhancer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export class GitHubIssueAppendEnhancer
const number = parseInt(numberStr!, 10)
const unique_key = `github.com:${slug}:${number}`
const title = document
.querySelector("main h2")!
.querySelector("main h1")!
.textContent!.replace(/\s*#\d+$/, "")
.trim()
return {
Expand Down
1,052 changes: 164 additions & 888 deletions tests/corpus/gh_issue.html
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions tests/lib/enhancers/__snapshots__/gh-detection.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ exports[`github detection > gh_issue_edit:should detect correct spots 1`] = `
"domain": "github.com",
"number": 56,
"slug": "diffplug/gitcasso",
"title": "Description",
"title": "what about the draft?",
"type": "GH_ISSUE_APPEND",
"unique_key": "github.com:diffplug/gitcasso:56",
},
Expand Down Expand Up @@ -64,7 +64,7 @@ exports[`github detection > gh_issue_edit_multiple:should detect correct spots 1
"domain": "github.com",
"number": 3,
"slug": "diffplug/testing-deletable",
"title": "Description",
"title": "Test 3",
"type": "GH_ISSUE_APPEND",
"unique_key": "github.com:diffplug/testing-deletable:3",
},
Expand Down
4 changes: 2 additions & 2 deletions tests/lib/enhancers/__snapshots__/gh-ui.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ exports[`github ui > gh_issue_edit:should render correct UI elements 1`] = `
[
{
"for": "id=:ra7: name=null className=prc-Textarea-TextArea-13q4j overtype-input",
"title": "Description",
"title": "what about the draft?",
"upperDecoration": <React.Fragment>
<span
className="flex h-4 w-4 flex-shrink-0 items-center justify-center"
Expand Down Expand Up @@ -60,7 +60,7 @@ exports[`github ui > gh_issue_edit_multiple:should render correct UI elements 1`
[
{
"for": "id=:r5b: name=null className=prc-Textarea-TextArea-13q4j overtype-input",
"title": "Description",
"title": "Test 3",
"upperDecoration": <React.Fragment>
<span
className="flex h-4 w-4 flex-shrink-0 items-center justify-center"
Expand Down