Skip to content

SMT2: allow unary bitand, bitor, bitxor #8794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2025
Merged

SMT2: allow unary bitand, bitor, bitxor #8794

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 24 additions & 30 deletions src/solvers/smt2/smt2_conv.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1301,46 +1301,40 @@ void smt2_convt::convert_expr(const exprt &expr)
{
convert_constant(to_constant_expr(expr));
}
else if(expr.id() == ID_concatenation && expr.operands().size() == 1)
{
DATA_INVARIANT_WITH_DIAGNOSTICS(
expr.type() == expr.operands().front().type(),
"concatenation over a single operand should have matching types",
expr.pretty());

convert_expr(expr.operands().front());
}
else if(
expr.id() == ID_concatenation || expr.id() == ID_bitand ||
expr.id() == ID_bitor || expr.id() == ID_bitxor)
{
DATA_INVARIANT_WITH_DIAGNOSTICS(
expr.operands().size() >= 2,
"given expression should have at least two operands",
!expr.operands().empty(),
"given expression should have at least one operand",
expr.id_string());

out << "(";

if(expr.id()==ID_concatenation)
out << "concat";
else if(expr.id()==ID_bitand)
out << "bvand";
else if(expr.id()==ID_bitor)
out << "bvor";
else if(expr.id()==ID_bitxor)
out << "bvxor";
else if(expr.id()==ID_bitnand)
out << "bvnand";
else if(expr.id()==ID_bitnor)
out << "bvnor";

for(const auto &op : expr.operands())
if(expr.operands().size() == 1)
{
out << " ";
flatten2bv(op);
flatten2bv(expr.operands().front());
}
else // >= 2
{
out << '(';

out << ")";
if(expr.id() == ID_concatenation)
out << "concat";
else if(expr.id() == ID_bitand)
out << "bvand";
else if(expr.id() == ID_bitor)
out << "bvor";
else if(expr.id() == ID_bitxor)
out << "bvxor";

for(const auto &op : expr.operands())
{
out << ' ';
flatten2bv(op);
}

out << ')';
}
}
else if(
expr.id() == ID_bitxnor || expr.id() == ID_bitnand ||
Expand Down
Loading