Skip to content

Conversation

@tautschnig
Copy link
Collaborator

Add a rule to also permit GCC attributes (C23 attributes already worked) before contract clauses attached to functions. This is at the expense of creating additional shift/reduce conflicts in our parser.

Fixes: #8685

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Add a rule to also permit GCC attributes (C23 attributes already worked)
before contract clauses attached to functions. This is at the expense of
creating additional shift/reduce conflicts in our parser.

Fixes: diffblue#8685
@kroening
Copy link
Collaborator

Add a rule to also permit GCC attributes (C23 attributes already worked) before contract clauses attached to functions. This is at the expense of creating additional shift/reduce conflicts in our parser.

Please don't -- at great pain I have so far managed to keep conflicts out of the grammar!

One you start accumulating these, they become impossible to debug.

@tautschnig tautschnig self-assigned this Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

goto-cc fails to parse declaration with attributes before contract clauses

2 participants