Skip to content

Conversation

@tautschnig
Copy link
Collaborator

  • Update NaN check condition to require infinity in nominator
  • Add regression tests to validate IEEE 754 infinity arithmetic

Fixes: #8634

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig marked this pull request as draft November 30, 2025 22:41
@tautschnig tautschnig force-pushed the fix-8634-inf-nan branch 2 times, most recently from 81bf5e7 to 4e48600 Compare December 2, 2025 03:24
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 52.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.00%. Comparing base (1505c36) to head (5578125).

Files with missing lines Patch % Lines
src/solvers/smt2/smt2_parser.cpp 25.00% 12 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8745   +/-   ##
========================================
  Coverage    80.00%   80.00%           
========================================
  Files         1700     1700           
  Lines       188254   188273   +19     
  Branches        73       73           
========================================
+ Hits        150615   150631   +16     
- Misses       37639    37642    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tautschnig tautschnig force-pushed the fix-8634-inf-nan branch 2 times, most recently from 1ff0d85 to 1871271 Compare December 2, 2025 04:58
- Update NaN check condition to require infinity in nominator
- Add regression tests to validate IEEE 754 infinity arithmetic
- Support __builtin_isfinite GCC built-in in C front-end
- Add __isfinite{,f,l} models of *BSD functions to C library
- Support fp.is{Negative,Positive} in the in-tree SMT2 solver

Fixes: diffblue#8634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Divide by +INFINITY raises NaN failure with --nan-check even when numerator is a finite number

1 participant