signup page #37
Open
signup page #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmedtz
reviewed
Oct 23, 2020
|
|
||
|
|
||
| class SignUpForm(forms.ModelForm): | ||
| first_name = forms.CharField(max_length=30, required=False, help_text='Optional.') |
Owner
There was a problem hiding this comment.
CustomUser model has no firstname field
devmedtz
reviewed
Oct 23, 2020
|
|
||
| class SignUpForm(forms.ModelForm): | ||
| first_name = forms.CharField(max_length=30, required=False, help_text='Optional.') | ||
| last_name = forms.CharField(max_length=30, required=False, help_text='Optional.') |
Owner
There was a problem hiding this comment.
CustomUser model has no lastname field
devmedtz
reviewed
Oct 23, 2020
| class SignUpForm(forms.ModelForm): | ||
| first_name = forms.CharField(max_length=30, required=False, help_text='Optional.') | ||
| last_name = forms.CharField(max_length=30, required=False, help_text='Optional.') | ||
| email = forms.CharField(max_length=254, help_text='Required. Inform a valid email address.') |
Owner
There was a problem hiding this comment.
This is already defined in models
devmedtz
reviewed
Oct 23, 2020
| first_name = forms.CharField(max_length=30, required=False, help_text='Optional.') | ||
| last_name = forms.CharField(max_length=30, required=False, help_text='Optional.') | ||
| email = forms.CharField(max_length=254, help_text='Required. Inform a valid email address.') | ||
| phone_number = forms.CharField(max_length=15, required=False, help_text='Optional.') |
Owner
There was a problem hiding this comment.
This is already defined on models, Don't repeat yourself
devmedtz
reviewed
Oct 23, 2020
| class Meta: | ||
| model = User | ||
| fields = ['name', 'email', 'phone'] | ||
| fields = ('first_name', 'last_name', 'email','phone_number', 'password1', 'password2', ) |
Owner
There was a problem hiding this comment.
fields should be a name, email, and phone, due to the CustomUser model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.