Skip to content

Resolve #178 | Type error: Type 'string | undefined' is not assignable to type 'string'. #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Resolve #178 | Type error: Type 'string | undefined' is not assignable to type 'string'. #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/core/theme-provider/emotion-cache.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export default function NextAppDirEmotionCacheProvider(props: NextAppDirEmotionC
let styles = '';
let dataEmotionAttribute = registry.cache.key;

const globals: { name: string; style: string }[] = [];
const globals: { name: string; style: string | undefined }[] = [];

inserted.forEach(({ name, isGlobal }) => {
const style = registry.cache.inserted[name];
Expand All @@ -63,7 +63,7 @@ export default function NextAppDirEmotionCacheProvider(props: NextAppDirEmotionC
if (isGlobal) {
globals.push({ name, style });
} else {
styles += style;
styles += style || "";
dataEmotionAttribute += ` ${name}`;
}
}
Expand All @@ -74,7 +74,7 @@ export default function NextAppDirEmotionCacheProvider(props: NextAppDirEmotionC
{globals.map(
({ name, style }): React.JSX.Element => (
<style
dangerouslySetInnerHTML={{ __html: style }}
dangerouslySetInnerHTML={{ __html: style || "" }}
data-emotion={`${registry.cache.key}-global ${name}`}
key={name}
/>
Expand Down