Skip to content

Conversation

@jbusecke
Copy link
Collaborator

@jbusecke jbusecke commented Oct 8, 2025

Replacing #96 since we cannot deploy to sandbox from a fork.

Depends on #95 and developmentseed/titiler#1235

Tasks

@jbusecke
Copy link
Collaborator Author

jbusecke commented Oct 8, 2025

@jbusecke
Copy link
Collaborator Author

jbusecke commented Nov 8, 2025

Still fighting with pre commit here, but I think this should be minor. Shouldn't preclude any kind of review.

@jbusecke
Copy link
Collaborator Author

Just added auth for the RASI data and it immedately worked with titiler-multidim! RASI map

- name: Run tests
run: uv run pytest
run: uv run pytest -n auto
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added pytest-xdist mostly for more performant tests locally. Does not do much on a 2 core gh runner.

Remove installation of system dependencies for compilation.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should probably take those out?


authorize_virtual_chunk_access = authorize_virtual_chunk_access or {}

print(f"DEBUG: authorize_virtual_chunk_access = {authorize_virtual_chunk_access}")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print(f"DEBUG: authorize_virtual_chunk_access = {authorize_virtual_chunk_access}")

assert response.status_code == 200
assert response.json() == ds_params["variables"]
# TODO: Do we care about the order?
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hrodmn just a flag here. I think we don't but let me know if I am missing anything here.


[dependency-groups]
dev = [
"dask>=2025.9.1",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was beneficial for generating the test fixtures, but happy to remove it if you think that I should.

@jbusecke
Copy link
Collaborator Author

@hrodmn this is ready for a review! Please ignore the tons of files in the test fixtures (sorry they clobber the diff quite a bit).

@hrodmn hrodmn self-requested a review November 12, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants