-
Notifications
You must be signed in to change notification settings - Fork 10
Support icechunk #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Support icechunk #101
Conversation
Co-authored-by: Henry Rodman <henry.rodman@gmail.com>
|
Still fighting with pre commit here, but I think this should be minor. Shouldn't preclude any kind of review. |
|
Just added auth for the RASI data and it immedately worked with titiler-multidim! RASI map |
| - name: Run tests | ||
| run: uv run pytest | ||
| run: uv run pytest -n auto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added pytest-xdist mostly for more performant tests locally. Does not do much on a 2 core gh runner.
Remove installation of system dependencies for compilation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should probably take those out?
src/titiler/multidim/reader.py
Outdated
|
|
||
| authorize_virtual_chunk_access = authorize_virtual_chunk_access or {} | ||
|
|
||
| print(f"DEBUG: authorize_virtual_chunk_access = {authorize_virtual_chunk_access}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| print(f"DEBUG: authorize_virtual_chunk_access = {authorize_virtual_chunk_access}") |
| assert response.status_code == 200 | ||
| assert response.json() == ds_params["variables"] | ||
| # TODO: Do we care about the order? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hrodmn just a flag here. I think we don't but let me know if I am missing anything here.
|
|
||
| [dependency-groups] | ||
| dev = [ | ||
| "dask>=2025.9.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was beneficial for generating the test fixtures, but happy to remove it if you think that I should.
|
@hrodmn this is ready for a review! Please ignore the tons of files in the test fixtures (sorry they clobber the diff quite a bit). |
Replacing #96 since we cannot deploy to sandbox from a fork.
Depends on #95 and developmentseed/titiler#1235
Tasks