Add support for GeogTOWGS84GeoKey #131
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxrjones
changed the title
kylebarron
reviewed
Nov 7, 2025
src/cog.rs
Outdated
| #[tokio::test] | ||
| async fn tmp_towgs84() { | ||
| let folder = "/Users/kyle/github/developmentseed/async-tiff"; | ||
| let path = object_store::path::Path::parse("USGS_13_s14w171.tif").unwrap(); |
Member
There was a problem hiding this comment.
Would you be able to create like a one-pixel version of this file to check into the tests?
Maybe try
gdal_translate input.tif output_1px.tif -srcwin 0 0 1 1
to copy just the upper-left-most pixel of the file.
You'd want to manually check that the desired header still exists.
Member
Author
There was a problem hiding this comment.
It does not, I'd need to specifically compile GDAL to read and write that part of the header. The wheels on PyPI will drop the TAG during GDAL translate.
I can do that if you think it's necessary.
kylebarron
reviewed
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the failure related to virtual-zarr/virtual-tiff#52.
I added instructions for downloading the file rather than subsetting and committing the file because gdal drops the problematic tag.
This looks to be a tag that was proposed as an addition to the GeoTIFF standard but never actually added to the spec - https://github.com/OSGeo/gdal/blob/657c5e4a4fb5b1389fd800ea9cc964435ad89a18/frmts/gtiff/libgeotiff/geokeys.inc#L34.
xref https://trac.osgeo.org/geotiff/wiki/TOWGS84GeoKey