fix: macos_configuration_profile_plist remove indentation from plist encoder when updating #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s (11.19) (deploymenttheory#845) refactor: jamf_cloud_distribution_service changes for Jamf Pro 11.19
…1.19) (deploymenttheory#848) feat: Add username attribute claim mapping to jamfpro_sso_settings for 11.19
…ment_settings (deploymenttheory#849) feat: Add enable_maid_username_merge option for user initiated enrollment settings
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…theory#853) Bumps [golang.org/x/text](https://github.com/golang/text) from 0.27.0 to 0.28.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.27.0...v0.28.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-version: 0.28.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… encoder when updating
neilmartin83
temporarily deployed
to
provider-integration-testing-external
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Summary
Removes the forced space indent conversion when updating profiles.
This makes no visible difference to profile content in the UI for custom payloads and fixes an issue where Associated Domains are removed by Jamf Pro when the payload uses space indents.
I also tried with the indent set to a tab instead of 4 spaces, which worked too. But just opted to remove it in the end. Please let me know if you'd prefer a tab instead - it doesn't seem to make a functional difference from what I can see but I could be missing something.
Issue Reference
Fixes #933
Motivation and Context
Dependencies
Type of Change
Please mark the relevant option with an
x:Testing
Quality Checklist
Screenshots/Recordings (if appropriate)
[Add screenshots or recordings that demonstrate the changes]
Additional Notes
[Add any additional information that might be helpful for reviewers]