Skip to content

Conversation

@DrakeLin
Copy link
Collaborator

@DrakeLin DrakeLin commented Nov 22, 2025

What changes are proposed in this pull request?

Refactored custom is_x_supported() and is_x_enabled() functions in table_configuration.rs to use the generic is_feature_enabled(&TableFeature) and is_feature_supported(&TableFeature) functions

How was this change tested?

Several test tables had invalid protocols where delta.enableChangeDataFeed=true was set but the protocol (3,7 with table features) didn't include changeDataFeed in writerFeatures. This is invalid because table features protocol requires explicit feature listing. Fixed:

  • cdf-column-mapping-name-mode-3-7.tar.zst - added changeDataFeed to writerFeatures
  • cdf-table-with-dv.tar.zst - added changeDataFeed to writerFeatures, removed macOS AppleDouble cruft
  • table-with-cdf/ - downgraded from protocol 3,7 (empty features) to legacy protocol 1,4 which implicitly supports CDF
  • The FFI tests used minWriterVersion: 2 but CDF requires minWriterVersion: 4

@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.77%. Comparing base (3700e80) to head (42cac70).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1519      +/-   ##
==========================================
+ Coverage   84.73%   84.77%   +0.04%     
==========================================
  Files         124      126       +2     
  Lines       34227    34102     -125     
  Branches    34227    34102     -125     
==========================================
- Hits        29001    28909      -92     
+ Misses       3816     3785      -31     
+ Partials     1410     1408       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the breaking-change Change that require a major version bump label Nov 22, 2025
@DrakeLin DrakeLin force-pushed the drake-lin_data/refactor-x-enabled-and-supported branch 2 times, most recently from 1a02a79 to e2b7987 Compare December 2, 2025 01:27
@DrakeLin DrakeLin force-pushed the drake-lin_data/refactor-x-enabled-and-supported branch from 262bf8c to ab09aea Compare December 2, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Change that require a major version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant