Skip to content

fix(deps): update dependency react-svg-pan-zoom to v3.13.1 #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(deps): update dependency react-svg-pan-zoom to v3.13.1 #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2522,7 +2522,7 @@
"react-dom": "^16.5.2",
"react-error-boundary": "^6.0.0",
"react-redux": "^7.1.1",
"react-svg-pan-zoom": "3.9.0",
"react-svg-pan-zoom": "3.13.1",
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

⚠️ React version compatibility issue: verify project uses React 17+ before merging.

The library upgraded to React 17 in v3.10, but the project specifies React ^16.5.2 (line 2215). This dependency spans 3.9.0 → 3.13.1, which likely breaks compatibility. Additionally, v3.13 removed deprecated defaultProps—confirm no impact on usage.

Run tests and verify React version before merge.

🏁 Script executed:

#!/bin/bash
# Find where react-svg-pan-zoom is actually used in the codebase
fd -e ts -e tsx -e js -e jsx -exec grep -l "react-svg-pan-zoom\|ReactSVGPanZoom" {} \;

# Check for any props usage patterns
rg -A 3 -B 3 "from.*react-svg-pan-zoom|import.*ReactSVGPanZoom" --type ts --type tsx

Length of output: 247

🏁 Script executed:

#!/bin/bash
# Search for react-svg-pan-zoom imports and usage
rg "react-svg-pan-zoom|ReactSVGPanZoom" --type ts -A 2 -B 2

# Check React version in package.json
rg '"react":' package.json

Length of output: 4252

🌐 Web query:

react-svg-pan-zoom 3.10 React version requirement

💡 Result:

react-svg-pan-zoom v3.10 migrated the library to React 17 (i.e., requires React 17). [1][2]

Sources:

  1. npm package changelog (react-svg-pan-zoom) — notes for v3.10: "Migrates to React 17...". [npm]. [1]
  2. Libraries.io / package changelog — v3.10: "Migrates to React 17 and Storybook 6...". [2]

⚠️ CRITICAL: React 17 requirement breaks compatibility with project's React 16.5.2

react-svg-pan-zoom v3.10 requires React 17, but the project uses React ^16.5.2. The upgrade to 3.13.1 will break svgViewer.tsx, toolbar.tsx, and mainPanel.tsx which actively depend on this library.

Either downgrade to 3.9.x, upgrade React to 17+, or reject this PR.

🤖 Prompt for AI Agents 
In package.json around line 2220, the bump of react-svg-pan-zoom to 3.13.1
introduces a React 17 requirement that breaks our codebase which uses React
^16.5.2; revert this change by pinning react-svg-pan-zoom to a 3.9.x release (or
other 3.10-compatible 16.x-safe version) or alternatively upgrade the project
React/deps to 17+ and update any typings/usages accordingly; after changing
package.json, run a fresh install, run unit/CI tests and verify svgViewer.tsx,
toolbar.tsx and mainPanel.tsx compile and behave (or update them for React 17)
before merging.

"react-svgmt": "1.1.11",
"react-vega": "^7.7.1",
"react-virtualized": "^9.21.1",
Expand Down
Loading