Refactor PostgreSQLExecutor to support Windows compatibility for process management #1182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboy1337
commented
Aug 30, 2025
tboy1337
commented
- Introduced _get_base_command method to dynamically set the base command for PostgreSQL based on the operating system.
- Added _windows_terminate_process method to handle process termination on Windows, ensuring graceful shutdown before force-killing.
- Updated stop method to utilize the new Windows-specific termination logic.
…ess management - Introduced _get_base_command method to dynamically set the base command for PostgreSQL based on the operating system. - Added _windows_terminate_process method to handle process termination on Windows, ensuring graceful shutdown before force-killing. - Updated stop method to utilize the new Windows-specific termination logic.
for more information, see https://pre-commit.ci
Open
fizyk
reviewed
Sep 4, 2025
- Updated _get_base_command method to provide a unified command format for both Windows and Unix systems, eliminating the use of single quotes around configuration values. - Simplified process termination logic by removing platform checks from the _windows_terminate_process method, ensuring consistent behavior across operating systems. - Enhanced tests to verify that the base command format is consistent across platforms.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.