Skip to content

Conversation

@mfranzke
Copy link
Collaborator

@mfranzke mfranzke commented Nov 7, 2025

Proposed changes

Some imports would benefit be a clear important statement with a node: prefix.

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/chore-optimized-code

@mfranzke mfranzke self-assigned this Nov 7, 2025
@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Nov 7, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in UX Engineering Team Backlog Nov 7, 2025
@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2025

⚠️ No Changeset found

Latest commit: 3d3797f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mfranzke mfranzke moved this from 🏗 In progress to 🎁 Ready for review in UX Engineering Team Backlog Nov 7, 2025
@mfranzke mfranzke requested a review from Copilot November 7, 2025 21:54
@mfranzke mfranzke marked this pull request as ready for review November 7, 2025 21:54
@mfranzke mfranzke enabled auto-merge (squash) November 7, 2025 21:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes Node.js built-in module imports and improves code formatting consistency across Storybook configuration files.

  • Updates all Node.js built-in module imports from bare specifiers to use the node: protocol prefix
  • Fixes arrow function formatting to match project code style
  • Removes extraneous whitespace

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
storybooks/vue-storybook/.storybook/main.ts Updates path import to use node:path protocol
storybooks/react-storybook/.storybook/main.ts Updates path import to use node:path protocol
storybooks/angular-storybook/.storybook/main.ts Updates path import to use node:path protocol
storybooks/_storybook/.storybook/main.ts Updates path import to use node:path protocol and removes extraneous blank line
packages/foundations/assets/fonts/generate-eu-fonts.ts Updates path and url imports to use node: protocol and fixes arrow function spacing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: 🎁 Ready for review

Development

Successfully merging this pull request may close these issues.

2 participants