Skip to content

Conversation

@d-koppenhagen
Copy link
Contributor

@d-koppenhagen d-koppenhagen commented Oct 31, 2025

Proposed changes

Introduce new property closeButtonText to set the label for the close button when the DBDrawer is opened.
It passes the prop value to the inner DBDrawer prop closeButtonText.

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/feat-header-close-text-for-drawer

This label allows to set the label for the close button when the `DBDrawer` is opened.
It passes the prop value to the inner `DBDrawer` prop `closeButtonText`.
@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2025

🦋 Changeset detected

Latest commit: 303d2e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@db-ux/core-components Minor
@db-ux/ngx-core-components Minor
@db-ux/react-core-components Minor
@db-ux/wc-core-components Minor
@db-ux/v-core-components Minor
@db-ux/core-foundations Minor
@db-ux/core-stylelint Minor
@db-ux/core-migration Minor
@db-ux/agent-cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 📕documentation Improvements or additions to documentation 🏘components labels Oct 31, 2025
@nmerget nmerget moved this from 🏗 In progress to 🎁 Ready for review in UX Engineering Team Backlog Oct 31, 2025
@nmerget nmerget moved this from 🎁 Ready for review to 👀 Actively In Review in UX Engineering Team Backlog Oct 31, 2025
@nmerget nmerget moved this from 👀 Actively In Review to 🎶 Waiting for feedback in UX Engineering Team Backlog Oct 31, 2025
@d-koppenhagen d-koppenhagen requested a review from nmerget October 31, 2025 09:18
@nmerget nmerget added this to the 4.2.0 milestone Oct 31, 2025
@nmerget nmerget moved this from 🎶 Waiting for feedback to ⏰ready for release in UX Engineering Team Backlog Oct 31, 2025
@d-koppenhagen d-koppenhagen changed the title feat(DBHeader): introduce new property closeDrawerLabel feat(DBHeader): introduce new property closeButtonText Nov 2, 2025
@d-koppenhagen d-koppenhagen enabled auto-merge (squash) November 2, 2025 07:42
@mfranzke mfranzke disabled auto-merge November 4, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏘components 📕documentation Improvements or additions to documentation

Projects

Status: ⏰ready for release

Development

Successfully merging this pull request may close these issues.

3 participants