fix: set DBTabItem selected state correctly #5399
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to 🏗 In progress
in UX Engineering Team Backlog
🦋 Changeset detectedLatest commit: d3c5b8d The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
🏘components
📕documentation
d-koppenhagen
previously approved these changes
Oct 31, 2025
nmerget
reviewed
Oct 31, 2025
| props.onChange(event); | ||
| } | ||
|
|
||
| // We have different ts types in different frameworks, so we need to use any here |
Collaborator
There was a problem hiding this comment.
Maybe we can keep this - the aria snapshots changed so it might be good to keep those additonally
Set (aria-)selected state via listener on parent tablist to also react on de-selection of item.
use var instead of file to hold click event results for test duration
Now also sets aria-selected=true|false correctly which improves screen reader behaviour.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
set child active after event registered, remove event listerner on unmount
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
add more checks and guardrails to TabItem on change events
milan-w
force-pushed
the
fix-tab-item-selected-state
branch
from
ee7cfbe to
d1535e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set (aria-)selected state via listener on parent tablist to also react on de-selection of item. Closes #5288
Proposed changes
Each tab item holds an internal state
_selectedto keep track of the active tab. However before this change the state function did not correctly react to a de-selection because the event was only triggered on the newly active tab.Now each item registers an event listener on the parent component and sets de/selected according to this event.
The playwright test for the tab components has also been refactored slightly to eliminate an unneccesary file write process.
Types of changes
Bugfix (non-breaking change that fixes an issue)
New feature (non-breaking change which adds functionality)
Refactoring (improvements to existing components or architectural decisions)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Update (if none of the other choices apply)
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)
🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/fix-tab-item-selected-state