Skip to content

feat: added merge groups #3896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: added merge groups #3896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ab4fe4
feat: added merge groups
mfranzke Mar 4, 2025
264431d
merge
mfranzke Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ permissions:

on:
pull_request:
merge_group:
Copy link

Copilot AI Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The merge_group event trigger is added without branch filtering, unlike in the other workflows. Consider adding a branch specification (e.g., branches: ["main"]) to ensure consistency.

Suggested change
merge_group:
merge_group:
branches:
- "main"

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The merge_group trigger should specify branches for consistency with the other workflow files. Consider adding 'branches: ["main"]' to match the pattern used in pull-request.yml and pull-request-opened.yml.

Suggested change
merge_group:
merge_group:
branches:
- "main"

Copilot uses AI. Check for mistakes.
push:
branches:
- "main"
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ name: On-PR to main
on:
pull_request:
branches: ["main"]
merge_group:
branches: ["main"]

permissions:
pull-requests: write
Expand Down