Skip to content

fix coercion of ShallowAttributes values #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
morr wants to merge 9 commits into
base: master
Choose a base branch
from
Open

fix coercion of ShallowAttributes values #26

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6008302
fix coercion of ShallowAttributes values
morr Apr 8, 2019
cb0863a
Merge branch 'nil-strings'
morr Apr 8, 2019
8e66b0f
bugfix
morr Apr 8, 2019
9f0b031
add test for array of ShallowAttributes objects
morr Apr 9, 2019
d86efff
Merge branch 'nil-strings'
morr Apr 9, 2019
0138cd9
Merge branch 'fix-coercion'
morr Apr 9, 2019
217ef59
Merge remote-tracking branch 'original/master'
morr Jul 20, 2020
3f6431e
remove bundler restriction
morr Jul 20, 2020
cef697d
Merge pull request #1 from morr/update-original
morr Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/shallow_attributes/instance_methods.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,13 @@ def reset_attribute(attribute)
#
# @since 0.1.0
def coerce(value, _options = {})
self.attributes = value
self.attributes =
if value.class.included_modules.include?(ShallowAttributes)
value.to_h
else
value
end

self
end

Expand Down