Namespace change and Label HtmlHelper enhancement #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hey! I'll take a look at this next weekend with the intention of merging immediately if I can - moving house this week so everything is a little chaotic for the duration, so apologies for my tardy responses :) |
Owner
|
I'd go with atrophied ;) Thanks for the heads up - this should probably just collide with a "real" Nancy repo at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks so much for doing the heavy lifting getting this project up and running!
We're using this code in our Nancy+Razor project and I noticed some weirdness with Intellisense that appeared to be related to a namespace collision. There's a class in the 1.2 Nancy.ViewEngines.Razor assembly named Nancy.ViewEngines.Razor.HtmlHelpers, which conflicts with your Nancy.ViewEngines.Razor.HtmlHelpers namespace and makes Intellisense terribly unhappy.
While I was in there, I also added some code to have the LabelFor extensions use the DisplayName attribute if it is detected.