fix(ingest/iceberg): Extend iceberg source to allow role assumption #15288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
datahub-cyborg
bot
added
the
needs-review
sgomezvillamor
approved these changes
Nov 17, 2025
| catalog_config, GLUE_ROLE_ARN, AWS_ROLE_ARN | ||
| ) | ||
| if role_to_assume: | ||
| logger.debug( |
Contributor
There was a problem hiding this comment.
this should probably be info level
|
|
||
| sts_client = session.client("sts") | ||
| identity = sts_client.get_caller_identity() | ||
| logger.debug( |
| "Current role and the role we wanted to assume are the same, continuing without further assumption steps" | ||
| ) | ||
| else: | ||
| logger.debug(f"Assuming the role {role_to_assume}") |
| response = sts_client.assume_role( | ||
| RoleArn=role_to_assume, | ||
| RoleSessionName="session", | ||
| DurationSeconds=43200, |
Contributor
There was a problem hiding this comment.
this could be a constant and we could mention that 12h is the max we can set
RoleSessionName could be more descriptive
dgluong-datahub
pushed a commit
that referenced
this pull request
Nov 17, 2025
…15288) Co-authored-by: pedro93 <pedro.cls93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently pyiceberg library does not use
role-arnwhen connecting to Glue catalog (limits itself only to assume that role for s3 access). This is a workaround until such functionality is introduced inpyiceberg.