Skip to content

run smoke tests with es8 #15285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

run smoke tests with es8 #15285

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dec43c
run smoke tests with es8
chakru-r Nov 13, 2025
c22062c
temp
chakru-r Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/docker-unified.yml
View file
Open in desktop
Copy link
Contributor

@github-actions github-actions bot Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2129:style:2:3: Consider using { cmd1; cmd2; } >> file instead of individual redirects [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 150 in 7dec43c

run: |

Copy link
Contributor

@github-actions github-actions bot Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:5:115: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 308 in 7dec43c

run: |

Copy link
Contributor

@github-actions github-actions bot Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:3:117: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 365 in 7dec43c

run: |

Copy link
Contributor

@github-actions github-actions bot Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:5:102: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 682 in c22062c

run: |

Copy link
Contributor

@github-actions github-actions bot Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:5:116: Double quote to prevent globbing and word splitting [shellcheck]

datahub/.github/workflows/docker-unified.yml

Line 682 in c22062c

run: |

Original file line number Diff line number Diff line change
Expand Up @@ -427,14 +427,8 @@ jobs:
cypress_matrix="$cypress_matrix"',{"test_strategy":"cypress","batch_count":"'"$cypress_batch_count"'","batch":"'"$i"'"}'
done

includes=''
if [[ "${{ needs.setup.outputs.backend_change }}" == 'true' || "${{ needs.setup.outputs.smoke_test_change }}" == 'true' || "${{ needs.setup.outputs.publish }}" == 'true' ]]; then
includes="$python_matrix,$cypress_matrix"
elif [[ "${{ needs.setup.outputs.frontend_only }}" == 'true' ]]; then
includes="$cypress_matrix"
elif [[ "${{ needs.setup.outputs.ingestion_only }}" == 'true' ]]; then
includes="$python_matrix"
fi
includes="$python_matrix,$cypress_matrix"

echo "matrix={\"include\":[$includes] }" >> "$GITHUB_OUTPUT"

smoke_test:
Expand Down Expand Up @@ -540,6 +534,12 @@ jobs:
DATAHUB_ACTIONS_IMAGE: ${{ env.DATAHUB_ACTIONS_IMAGE }}
ACTIONS_EXTRA_PACKAGES: "acryl-datahub-actions[executor] acryl-datahub-actions"
ACTIONS_CONFIG: "https://raw.githubusercontent.com/acryldata/datahub-actions/main/docker/config/executor.yaml"
ELASTICSEARCH_SHIM_AUTO_DETECT: true
ELASTICSEARCH_SHIM_ENABLED: true
ELASTICSEARCH_SHIM_ENGINE_TYPE: AUTO_DETECT
DATAHUB_SEARCH_IMAGE: elasticsearch
DATAHUB_SEARCH_TAG: 8.17.10
DATAHUB_ANALYTICS_ENABLED: false
run: |
# Quickstart uses PROFILE_NAME env if defined to start the profile specified. Defaults to quickstart-consumers
./smoke-test/run-quickstart.sh
Expand Down
Loading