fix(bigquery): apply case normalization consistently for temp table inference #15252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
- Fix case sensitivity bug in is_allowed_table() discovered_tables lookup - Both is_temp_table() and is_allowed_table() now consistently use standardize_identifier_case() - Resolves 'not allowed table' debug messages for legitimate production tables - Ensures convert_urns_to_lowercase config is respected across all table lookups
github-actions
bot
requested a deployment
to
datahub-wheels (Preview)
… inference logs - Removed overly verbose table discovery debug logs from bigquery_schema_gen.py - Simplified temp table inference logging in queries_extractor.py - Kept the essential 'Inferred as temp table' message for troubleshooting - Case normalization fixes remain in place
sgomezvillamor
changed the title
datahub-cyborg
bot
added
the
needs-review
treff7es
approved these changes
Nov 24, 2025
| ): | ||
| logger.debug(f"inferred as temp table {name}") | ||
| logger.debug( | ||
| f"Inferred as temp table {name} (is_allowed?{self.filters.is_allowed(table)}" |
Contributor
There was a problem hiding this comment.
Is this correct?
A parenthesis is missing for sure, but I'm unsure if you wanted is_allowed there as a string with a question mark.
Contributor
Author
There was a problem hiding this comment.
I like using question mark for booleans 😅
indeed, parenthesis was missed, nice catch!
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
BigQuery lineage was missing due to a case sensitivity bug in the temp table inference logic. When
convert_urns_to_lowercase: trueis configured, legitimate production tables were incorrectly classified as temp tables, preventing lineage generation.Root Cause
The BigQuery connector had inconsistent case handling:
discovered_tablesset was correctly normalized to lowercase during initializationPRD_NAP_BASE_VWSvsprd_nap_base_vws), triggering false positive temp table inferenceFix Applied
Applied consistent case normalization in both
is_temp_table()andis_allowed_table()methods:standardize_identifier_case()when checking againstdiscovered_tablesconvert_urns_to_lowercaseconfiguration is respected across all table lookupsChanges
queries_extractor.py: Fixed case normalization in temp table and allowed table lookups