Ak/spec #372
Draft
Ak/spec #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #372 +/- ##
=========================================
Coverage ? 91.89%
=========================================
Files ? 49
Lines ? 4319
Branches ? 786
=========================================
Hits ? 3969
Misses ? 204
Partials ? 146 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anupkalburgi
commented
Nov 10, 2025
Comment on lines
+69
to
+72
| class FilePathTarget(BaseModel): | ||
| """Defines a file system path as the output destination for generated data. | ||
|
|
||
| This class represents a file system location where generated tables will be written |
Collaborator
Author
There was a problem hiding this comment.
Move the targets out to a diff module.
anupkalburgi
commented
Nov 10, 2025
Comment on lines
+139
to
+142
| class ValidationResult: | ||
| """Container for validation results that collects errors and warnings during spec validation. | ||
|
|
||
| This class accumulates validation issues found while checking a DatagenSpec configuration. |
Collaborator
Author
There was a problem hiding this comment.
Move it out, a diff module
anupkalburgi
commented
Nov 10, 2025
Comment on lines
+278
to
+282
| def generate_and_write_data( | ||
| self, | ||
| config: DatagenSpec, | ||
| config_source_name: str = "PydanticConfig" | ||
| ) -> None: |
Collaborator
Author
There was a problem hiding this comment.
saveAsDatasetFromSpec maybe? make it all CamelCase
anupkalburgi
commented
Nov 10, 2025
Comment on lines
+127
to
+131
| def _prepare_data_generators( | ||
| self, | ||
| config: DatagenSpec, | ||
| config_source_name: str = "PydanticConfig" | ||
| ) -> dict[str, dg.DataGenerator]: |
Collaborator
Author
There was a problem hiding this comment.
rename to buildFromSpec - all need to be CamelCase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Linked issues
Resolves #..
Requirements