fix: Restore fails with bufio.Scanner: token too long when importing large dump files #486
+30
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…large dump files Signed-off-by: chenen <itfunx@hotmail.com>
n2em
force-pushed
the
bugfix/restore/token-too-long
branch
from
6008f71 to
9250cc1
Compare
Collaborator
|
I guess #469 was not totally fixed? What is the root cause? Looking at the code here, it looks to me like you just recreated what scanner does? So why does this work? |
Author
|
The core issue lead to this bug is the const value of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug fix for #469