ci: add rudimentary CI check for WorkloadAllowlists #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the Helm value operator.gke.autopilot.enabled is true, deploy the Dash0 AllowlistSynchronizer so the Dash0 WorkloadAllowlist resources will be installed into the cluster. The resource is annotated as a Helm hook (pre-install,pre-upgrade) to make sure the WorkloadAllowlists are rolled out before the rest of the Helm chart, that is, before the operator manager deployment (since that workload already needs the node affinity exemption to be in place). Additionally, lift the following feature set restrictions in GKE Autopilot mode: - allow node affinities on GKE Autopilot - enable host metrics receiver on GKE Autopilot
basti1302
force-pushed
the
check-workload-allowlist-in-ci
branch
3 times, most recently
from
921c429 to
531e6e6
Compare
The intend is that this check fails if we change the Dash0 operator workloads in a way that make an update of the related WorkloadAllowlists necessary. The script currently does not check with every possible combination of Helm settings, but only checks a typical installation. There might be cases that we miss. Testing every possible combination seems excessive at the moment, but we might want to iterate on this in the future.
basti1302
force-pushed
the
check-workload-allowlist-in-ci
branch
from
531e6e6 to
69ca4ec
Compare
basti1302
force-pushed
the
check-workload-allowlist-in-ci
branch
from
be0d52b to
8c3db2a
Compare
basti1302
force-pushed
the
check-workload-allowlist-in-ci
branch
from
78ae7d5 to
eb70da3
Compare
Member
Author
|
The check fails if the WorkloadAllowlist does not match our workload anymore: https://github.com/dash0hq/dash0-operator/actions/runs/19151058124/job/54741125962 
|
This reverts commit eb70da3. [skip ci]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PR, #571 needs to be merged first.