-
Notifications
You must be signed in to change notification settings - Fork 291
Clean up pybind11 leftovers after nanobind migration #2256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
dart/.github/workflows/publish_dartpy.yml
Lines 87 to 92 in 54369a6
| - name: Prepare pixi home | |
| if: (matrix.skip-on-commit != true) || github.event_name == 'pull_request' || startsWith(github.ref, 'refs/tags/v') | |
| run: | | |
| rm -f "$HOME/.pixi/bin/pixi" | |
| mkdir -p "${HOME}/.pixi/bin" | |
The workflow now includes windows-latest runners, but the first run step still uses POSIX-only commands (rm -f, mkdir -p) without setting shell: bash. On Windows the default shell is PowerShell, so these commands fail before any wheel build runs, meaning the newly added Windows matrix entries will always error out rather than producing wheels.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ind11 # Conflicts: # docs/onboarding/python-bindings.md
…ind11 # Conflicts: # .github/workflows/ci_ubuntu.yml
Follow-up to #2249 to finish the nanobind migration and remove pybind11 remnants.
nanobind.stubgen.-DDART_USE_SYSTEM_PYBIND11flag from the pixi CMake config and refresh locale strings so user-facing docs no longer mention pybind11.Testing: Not run (CI will cover).