Skip to content

Conversation

@jslee02
Copy link
Member

@jslee02 jslee02 commented Nov 24, 2025

Follow-up to #2249 to finish the nanobind migration and remove pybind11 remnants.

  • Docs: update onboarding and python-bindings guides to describe the nanobind-based bindings and switch stub generation to nanobind.stubgen.
  • CI: enable Linux/macOS wheel builds for Python 3.12/3.13/3.14; Windows wheels removed from this PR and will be handled separately. sccache env setup removed from publish workflow to avoid post-job stats failures.
  • Tooling: drop the stale -DDART_USE_SYSTEM_PYBIND11 flag from the pixi CMake config and refresh locale strings so user-facing docs no longer mention pybind11.

Testing: Not run (CI will cover).

@jslee02 jslee02 added this to the DART 7.0 milestone Nov 24, 2025
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

- name: Prepare pixi home
if: (matrix.skip-on-commit != true) || github.event_name == 'pull_request' || startsWith(github.ref, 'refs/tags/v')
run: |
rm -f "$HOME/.pixi/bin/pixi"
mkdir -p "${HOME}/.pixi/bin"

P1 Badge Windows wheel jobs run POSIX commands with PowerShell default

The workflow now includes windows-latest runners, but the first run step still uses POSIX-only commands (rm -f, mkdir -p) without setting shell: bash. On Windows the default shell is PowerShell, so these commands fail before any wheel build runs, meaning the newly added Windows matrix entries will always error out rather than producing wheels.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jslee02 jslee02 enabled auto-merge (squash) November 25, 2025 00:19
@jslee02 jslee02 disabled auto-merge November 25, 2025 00:19
@jslee02 jslee02 merged commit 0f9b19b into main Nov 25, 2025
8 of 31 checks passed
@jslee02 jslee02 deleted the feature/nb_cleaup_pybind11 branch November 25, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants