Add unnecessary_lambdas lint (#1978)

* Validate only needed summaries in expression_compiler_service

* Add avoid_void_async lint

* Add unnecessary_lambdas lint

Author: Anna Gringauze

dwds/analysis_options.yaml

@@ -20,3 +20,4 @@ linter:
     - prefer_final_locals
     - unawaited_futures
     - avoid_void_async
+    - unnecessary_lambdas

dwds/debug_extension_mv3/web/settings.dart

@@ -48,9 +48,7 @@ void _showSavedMsg() {
   final snackbar = document.getElementById('savedSnackbar');
   if (snackbar == null) return;
   snackbar.classes.add('show');
-  Timer(Duration(seconds: 3), () {
-    _maybeHideSavedMsg();
-  });
+  Timer(Duration(seconds: 3), _maybeHideSavedMsg);
 }
 
 void _maybeHideSavedMsg() {

dwds/debug_extension_mv3/web/utils.dart

@@ -30,21 +30,15 @@ Future<Tab> createTab(String url, {bool inNewWindow = false}) {
         active: true,
         url: url,
       ),
-      allowInterop(
-        (Tab tab) {
-          completer.complete(tab);
-        },
-      ),
+      allowInterop(completer.complete),
     );
   }
   return completer.future;
 }
 
 Future<Tab?> getTab(int tabId) {
   final completer = Completer<Tab?>();
-  chrome.tabs.get(tabId, allowInterop((tab) {
-    completer.complete(tab);
-  }));
+  chrome.tabs.get(tabId, allowInterop(completer.complete));
   return completer.future;
 }
 

dwds/lib/src/debugging/location.dart

@@ -271,8 +271,7 @@ class Locations {
   ///
   /// This will populate the [_sourceToLocation] and [_moduleToLocations] maps.
   Future<Set<Location>> _locationsForModule(String module) async {
-    final memoizer =
-        _locationMemoizer.putIfAbsent(module, () => AsyncMemoizer());
+    final memoizer = _locationMemoizer.putIfAbsent(module, AsyncMemoizer.new);
 
     return await memoizer.runOnce(() async {
       if (_moduleToLocations.containsKey(module)) {

dwds/lib/src/handlers/dev_handler.dart

@@ -160,7 +160,7 @@ class DevHandler {
           .takeUntilGap(const Duration(milliseconds: 50));
       // We enqueue this work as we need to begin listening (`.hasNext`)
       // before events are received.
-      safeUnawaited(Future.microtask(() => connection.runtime.enable()));
+      safeUnawaited(Future.microtask(connection.runtime.enable));
 
       await for (var contextId in contextIds) {
         final result = await connection.sendCommand('Runtime.evaluate', {

dwds/lib/src/services/chrome_proxy_service.dart

@@ -118,7 +118,7 @@ class ChromeProxyService implements VmServiceInterface {
       _skipLists,
       root,
     );
-    debugger.then((value) => _debuggerCompleter.complete(value));
+    debugger.then(_debuggerCompleter.complete);
   }
 
   static Future<ChromeProxyService> create(

dwds/test/extension_debugger_test.dart

@@ -40,9 +40,7 @@ void main() async {
         ..success = true);
       final resultCompleter = Completer();
       unawaited(extensionDebugger.sendCommand('Runtime.evaluate',
-          params: {'expression': '\$pi'}).then((response) {
-        resultCompleter.complete(response);
-      }));
+          params: {'expression': '\$pi'}).then(resultCompleter.complete));
       connection.controllerIncoming.sink
           .add(jsonEncode(serializers.serialize(extensionResponse)));
       final response = await resultCompleter.future;

dwds/test/fixtures/debugger_data.dart

@@ -11,8 +11,7 @@ import 'package:webkit_inspection_protocol/webkit_inspection_protocol.dart';
 ///
 /// This is taken from a real run, but truncated to two levels of scope and one
 /// level of stack.
-List<WipCallFrame> frames1 =
-    frames1Json.map((json) => WipCallFrame(json)).toList();
+List<WipCallFrame> frames1 = frames1Json.map(WipCallFrame.new).toList();
 
 List<Map<String, dynamic>> frames1Json = [
   {

dwds/test/instances/instance_inspection_common.dart

@@ -140,7 +140,7 @@ Matcher matchPrimitiveInstance(
         {required String kind, required dynamic value}) =>
     isA<Instance>()
         .having((e) => e.kind, 'kind', kind)
-        .having((e) => _getValue(e), 'value', value);
+        .having(_getValue, 'value', value);
 
 Matcher matchPlainInstance({required String type}) => isA<Instance>()
     .having((e) => e.kind, 'kind', InstanceKind.kPlainInstance)

dwds/test/sdk_configuration_test.dart

@@ -26,9 +26,8 @@ void main() {
 
     test('Cannot validate an empty configuration layout', () async {
       final emptyConfiguration = SdkConfiguration.empty();
-      expect(() => emptyConfiguration.validateSdkDir(),
-          _throwsDoesNotExistException);
-      expect(() => emptyConfiguration.validate(), _throwsDoesNotExistException);
+      expect(emptyConfiguration.validateSdkDir, _throwsDoesNotExistException);
+      expect(emptyConfiguration.validate, _throwsDoesNotExistException);
     });
   });
 
@@ -85,7 +84,7 @@ void main() {
       final sdkConfiguration = TestSdkLayout.createConfiguration(sdkLayout);
 
       sdkConfiguration.validateSdkDir();
-      expect(() => sdkConfiguration.validate(), _throwsDoesNotExistException);
+      expect(sdkConfiguration.validate, _throwsDoesNotExistException);
     });
   });