Add 'avoid_void_async' lint (#1977)

* Validate only needed summaries in expression_compiler_service

* Add avoid_void_async lint

Author: Anna Gringauze

dwds/analysis_options.yaml

@@ -19,3 +19,4 @@ linter:
     - directives_ordering
     - prefer_final_locals
     - unawaited_futures
+    - avoid_void_async

dwds/debug_extension/tool/copy_builder.dart

@@ -21,7 +21,7 @@ class _CopyBuilder extends Builder {
       };
 
   @override
-  void build(BuildStep buildStep) async {
+  Future<void> build(BuildStep buildStep) async {
     final inputAsset = buildStep.inputId;
     final allowedOutputs = buildStep.allowedOutputs;
 

dwds/debug_extension/web/background.dart

@@ -233,7 +233,7 @@ void _startDebugging(DebuggerTrigger debuggerTrigger) {
   }));
 }
 
-void _attachDebuggerToTab(Tab currentTab) async {
+Future<void> _attachDebuggerToTab(Tab currentTab) async {
   if (!_debuggableTabs.contains(currentTab.id)) return;
 
   if (_tabIdToWarning.containsKey(currentTab.id)) {
@@ -287,7 +287,7 @@ void _handleMessageFromPanelScript(Request request, MessageSender sender) {
   }
 }
 
-void _maybeMarkTabAsDebuggable(
+Future<void> _maybeMarkTabAsDebuggable(
     Request request, MessageSender sender, Function sendResponse) async {
   // Register any warnings for the tab:
   if (request.warning != '') {
@@ -300,7 +300,7 @@ void _maybeMarkTabAsDebuggable(
   sendResponse(true);
 }
 
-void _maybeAttachDebugSession(
+Future<void> _maybeAttachDebugSession(
   Debuggee source,
   String method,
   Object? params,
@@ -361,15 +361,15 @@ int _removeDebugSessionForTab(int tabId) {
   }
 }
 
-void _maybeSaveDevToolsTabId(Tab tab) async {
+Future<void> _maybeSaveDevToolsTabId(Tab tab) async {
   // Remembers the ID of the DevTools tab.
   //
   // This assumes that the next launched tab after a session is created is the
   // DevTools tab.
   if (_debugSessions.isNotEmpty) _debugSessions.last.devtoolsTabId ??= tab.id;
 }
 
-void _handleMessageFromExternalExtensions(
+Future<void> _handleMessageFromExternalExtensions(
     dynamic jsRequest, MessageSender sender, Function sendResponse) async {
   if (jsRequest == null) return;
   final request = jsRequest as Request;
@@ -408,7 +408,7 @@ void _handleMessageFromExternalExtensions(
   }
 }
 
-void _forwardMessageToExternalExtensions(
+Future<void> _forwardMessageToExternalExtensions(
     Debuggee source, String method, Object? params) async {
   if (_allowedEvents.contains(method)) {
     sendMessageToExtensions(ExternalExtensionRequest(

dwds/debug_extension_mv3/tool/copy_builder.dart

@@ -18,7 +18,7 @@ class _CopyBuilder extends Builder {
       };
 
   @override
-  void build(BuildStep buildStep) async {
+  Future<void> build(BuildStep buildStep) async {
     final inputAsset = buildStep.inputId;
     final allowedOutputs = buildStep.allowedOutputs;
 

dwds/debug_extension_mv3/web/background.dart

@@ -55,7 +55,7 @@ void _registerListeners() {
   ));
 }
 
-void _handleRuntimeMessages(
+Future<void> _handleRuntimeMessages(
     dynamic jsRequest, MessageSender sender, Function sendResponse) async {
   if (jsRequest is! String) return;
 
@@ -137,7 +137,8 @@ void _handleRuntimeMessages(
       });
 }
 
-void _detectNavigationAwayFromDartApp(NavigationInfo navigationInfo) async {
+Future<void> _detectNavigationAwayFromDartApp(
+    NavigationInfo navigationInfo) async {
   final tabId = navigationInfo.tabId;
   final debugInfo = await _fetchDebugInfo(navigationInfo.tabId);
   if (debugInfo == null) return;

dwds/debug_extension_mv3/web/cross_extension_communication.dart

@@ -27,16 +27,16 @@ final _eventsForAngularDartDevTools = {
   'dwds.encodedUri',
 };
 
-void handleMessagesFromAngularDartDevTools(
+Future<void> handleMessagesFromAngularDartDevTools(
     dynamic jsRequest, MessageSender sender, Function sendResponse) async {
   if (jsRequest == null) return;
   final message = jsRequest as ExternalExtensionMessage;
   if (message.name == 'chrome.debugger.sendCommand') {
     _forwardCommandToChromeDebugger(message, sendResponse);
   } else if (message.name == 'dwds.encodedUri') {
-    _respondWithEncodedUri(message.tabId, sendResponse);
+    await _respondWithEncodedUri(message.tabId, sendResponse);
   } else if (message.name == 'dwds.startDebugging') {
-    attachDebugger(message.tabId, trigger: Trigger.angularDartDevTools);
+    await attachDebugger(message.tabId, trigger: Trigger.angularDartDevTools);
     sendResponse(true);
   } else {
     sendResponse(
@@ -83,7 +83,7 @@ void _respondWithChromeResult(Object? chromeResult, Function sendResponse) {
   }
 }
 
-void _respondWithEncodedUri(int tabId, Function sendResponse) async {
+Future<void> _respondWithEncodedUri(int tabId, Function sendResponse) async {
   final encodedUri = await fetchStorageObject<String>(
       type: StorageObject.encodedUri, tabId: tabId);
   sendResponse(encodedUri ?? '');

dwds/debug_extension_mv3/web/debug_session.dart

@@ -104,7 +104,8 @@ bool get existsActiveDebugSession => _debugSessions.isNotEmpty;
 int? get latestAppBeingDebugged =>
     existsActiveDebugSession ? _debugSessions.last.appTabId : null;
 
-void attachDebugger(int dartAppTabId, {required Trigger trigger}) async {
+Future<void> attachDebugger(int dartAppTabId,
+    {required Trigger trigger}) async {
   // Check if a debugger is already attached:
   final existingDebuggerLocation = _debuggerLocation(dartAppTabId);
   if (existingDebuggerLocation != null) {
@@ -372,7 +373,8 @@ void _forwardChromeDebuggerEventToDwds(
   }
 }
 
-void _openDevTools(String devToolsUri, {required int dartAppTabId}) async {
+Future<void> _openDevTools(String devToolsUri,
+    {required int dartAppTabId}) async {
   if (devToolsUri.isEmpty) {
     debugError('DevTools URI is empty.');
     return;

dwds/debug_extension_mv3/web/devtools.dart

@@ -19,7 +19,7 @@ bool panelsExist = false;
 
 void main() async {
   _registerListeners();
-  _maybeCreatePanels();
+  await _maybeCreatePanels();
 }
 
 void _registerListeners() {
@@ -31,7 +31,7 @@ void _registerListeners() {
   }));
 }
 
-void _maybeCreatePanels() async {
+Future<void> _maybeCreatePanels() async {
   if (panelsExist) return;
   final tabId = chrome.devtools.inspectedWindow.tabId;
   final debugInfo = await fetchStorageObject<DebugInfo>(

dwds/debug_extension_mv3/web/settings.dart

@@ -23,15 +23,15 @@ void _registerListeners() {
   saveButton.addEventListener('click', _saveSettingsToStorage);
 }
 
-void _updateSettingsFromStorage(Event _) async {
+Future<void> _updateSettingsFromStorage(Event _) async {
   final devToolsOpener = await fetchStorageObject<DevToolsOpener>(
       type: StorageObject.devToolsOpener);
   final openInNewWindow = devToolsOpener?.newWindow ?? false;
   _getRadioButton('windowOpt').checked = openInNewWindow;
   _getRadioButton('tabOpt').checked = !openInNewWindow;
 }
 
-void _saveSettingsToStorage(Event event) async {
+Future<void> _saveSettingsToStorage(Event event) async {
   event.preventDefault();
   _maybeHideSavedMsg();
   final form = document.querySelector("form") as FormElement;

dwds/lib/src/debugging/debugger.dart

@@ -213,7 +213,7 @@ class Debugger extends Domain {
   Future<void> resumeFromStart() => _resumeHandler(null);
 
   /// Notify the debugger the [Isolate] is paused at the application start.
-  void notifyPausedAtStart() async {
+  void notifyPausedAtStart() {
     stackComputer = FrameComputer(this, []);
   }