-
Notifications
You must be signed in to change notification settings - Fork 78
Drop some stale ignores #2242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Drop some stale ignores #2242
Conversation
The `deprecated_member_use_from_same_package` are no longer reported at these locations and the analyzer now flags them an unnecessary ignores.
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes several stale deprecated_member_use_from_same_package ignores, which is a good cleanup. The changes are correct and align with the goal of removing unnecessary analyzer ignores. I have one suggestion regarding code formatting to improve readability in one of the test files.
|
I don't know the specific change upstream that cause these to become unnecessary but it's safe to remove them. |
PR HealthLicense Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with Breaking changes ✔️
This check can be disabled by tagging the PR with Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
Add empty changelog header since nothing user facing is changing yet and there is no need to publish.
The
deprecated_member_use_from_same_packageare no longer reportedat these locations and the analyzer now flags them an unnecessary
ignores.