-
Notifications
You must be signed in to change notification settings - Fork 78
Added the toJson method in Pubspec
#2011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the toJson method in Pubspec
#2011
Conversation
toJson method in Pubspec
|
@dart-lang/dart-bat any update here? |
|
Looks like we need a rebase? |
|
Sure I will rebase the branch and push. |
Co-authored-by: Moritz <mosum@google.com>
…ang#2077) This is to support using this package to write a dart analyzer LSP client, which requires String ids. Also closes dart-lang#738 This is technically breaking because there was some code which tries to coerce string ids back into integers, but this should never have happened. Any server stringifying integer IDs is not spec compliant. Let me know if we want to release this as non-breaking instead of breaking, I think it would be fine personally, but don't feel strongly either way.
…t-lang#1202) Signed-off-by: Goddchen <goddchen@gmail.com> Co-authored-by: Moritz <mosum@google.com>
|
I unborked the merge to the latest on If you decide on using a fresh PR you can create it from the content after the merge I made. Be sure to git commit -m "Add a toJson method on Pubspec
Closes #1801
- Added the `toJson` serializable to serialize object into `map`.
- Added tests to validate functionality round-trip the shape of the source.
- Updated `CHANGELOG.md` to document the changes." |
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with
Coverage
|
| File | Coverage |
|---|---|
| pkgs/pubspec_parse/lib/src/dependency.dart | 💚 80 % ⬆️ 10 % |
| pkgs/pubspec_parse/lib/src/pubspec.dart | 💚 98 % ⬆️ 0 % |
| pkgs/pubspec_parse/lib/src/screenshot.dart | 💔 95 % ⬇️ 5 % |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
API leaks ✔️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
| Package | Leaked API symbol | Leaking sources |
|---|
This check can be disabled by tagging the PR with skip-leaking-check.
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
| Files |
|---|
| pkgs/bazel_worker/benchmark/benchmark.dart |
| pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart |
| pkgs/boolean_selector/example/example.dart |
| pkgs/clock/lib/clock.dart |
| pkgs/clock/lib/src/clock.dart |
| pkgs/clock/lib/src/default.dart |
| pkgs/clock/lib/src/stopwatch.dart |
| pkgs/clock/lib/src/utils.dart |
| pkgs/clock/test/clock_test.dart |
| pkgs/clock/test/default_test.dart |
| pkgs/clock/test/stopwatch_test.dart |
| pkgs/clock/test/utils.dart |
| pkgs/coverage/lib/src/coverage_options.dart |
| pkgs/html/example/main.dart |
| pkgs/html/lib/dom.dart |
| pkgs/html/lib/dom_parsing.dart |
| pkgs/html/lib/html_escape.dart |
| pkgs/html/lib/parser.dart |
| pkgs/html/lib/src/constants.dart |
| pkgs/html/lib/src/encoding_parser.dart |
| pkgs/html/lib/src/html_input_stream.dart |
| pkgs/html/lib/src/list_proxy.dart |
| pkgs/html/lib/src/query_selector.dart |
| pkgs/html/lib/src/token.dart |
| pkgs/html/lib/src/tokenizer.dart |
| pkgs/html/lib/src/treebuilder.dart |
| pkgs/html/lib/src/utils.dart |
| pkgs/html/test/dom_test.dart |
| pkgs/html/test/parser_feature_test.dart |
| pkgs/html/test/parser_test.dart |
| pkgs/html/test/query_selector_test.dart |
| pkgs/html/test/selectors/level1_baseline_test.dart |
| pkgs/html/test/selectors/level1_lib.dart |
| pkgs/html/test/selectors/selectors.dart |
| pkgs/html/test/support.dart |
| pkgs/html/test/tokenizer_test.dart |
| pkgs/html/test/trie_test.dart |
| pkgs/html/tool/generate_trie.dart |
| pkgs/pubspec_parse/test/git_uri_test.dart |
| pkgs/stack_trace/example/example.dart |
| pkgs/watcher/test/custom_watcher_factory_test.dart |
| pkgs/yaml_edit/example/example.dart |
This check can be disabled by tagging the PR with skip-license-check.
|
I think it’ll be cleaner to start a fresh PR without the clutter. I’ll create a new one. Thanks a lot for your help, @kevmoo and @natebosch! |
|
I’ve created a new PR (#2214) with a clean history. We can close this one now. Thanks again for your help! |
Description
Fixes #1801 by adding
toJsonmethod inPubspecclass.Changes
toJsonserializable to serialize object intomap.CHANGELOG.mdto document the changes.Checklist