Skip to content

[ok_http] Fix: multiple Flutter engines would cause crash #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[ok_http] Fix: multiple Flutter engines would cause crash #1846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkgs/ok_http/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

- `OkHttpClient` now receives an `OkHttpClientConfiguration` to configure the client on a per-call basis.
- `OkHttpClient` supports setting four types of timeouts: [`connectTimeout`](https://square.github.io/okhttp/5.x/okhttp/okhttp3/-ok-http-client/-builder/connect-timeout.html), [`readTimeout`](https://square.github.io/okhttp/5.x/okhttp/okhttp3/-ok-http-client/-builder/read-timeout.html), [`writeTimeout`](https://square.github.io/okhttp/5.x/okhttp/okhttp3/-ok-http-client/-builder/write-timeout.html), and [`callTimeout`](https://square.github.io/okhttp/5.x/okhttp/okhttp3/-ok-http-client/-builder/call-timeout.html), using the `OkHttpClientConfiguration`.
- Upgrade to `jni` 0.14.0
- Upgrade to `jnigen` 0.14.0
- Upgrade to `jni` 0.15.0
- Upgrade to `jnigen` 0.15.0
- `OKHttpClient` supports client certificates.
- Support `package:web_socket` 1.0.0.
- Set `minSdk=24`.
Expand Down
16 changes: 8 additions & 8 deletions ...k_http/android/src/main/kotlin/com/example/ok_http/FixedResponseX509ExtendedKeyManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,25 +21,25 @@ class FixedResponseX509ExtendedKeyManager(
private val alias: String,
) : X509ExtendedKeyManager() {

override fun getClientAliases(keyType: String, issuers: Array<Principal>?) = arrayOf(alias)
override fun getClientAliases(keyType: String?, issuers: Array<Principal?>?) = arrayOf(alias)

override fun chooseClientAlias(
keyType: Array<String>,
issuers: Array<Principal>?,
keyType: Array<String?>?,
issuers: Array<Principal?>?,
socket: Socket?,
) = alias

override fun getServerAliases(keyType: String, issuers: Array<Principal>?) = arrayOf(alias)
override fun getServerAliases(keyType: String?, issuers: Array<Principal?>?) = arrayOf(alias)

override fun chooseServerAlias(
keyType: String,
issuers: Array<Principal>?,
keyType: String?,
issuers: Array<Principal?>?,
socket: Socket?,
) = alias

override fun getCertificateChain(alias: String) = certificateChain
override fun getCertificateChain(alias: String?) = certificateChain

override fun getPrivateKey(alias: String) = privateKey
override fun getPrivateKey(alias: String?) = privateKey

override fun chooseEngineClientAlias(
keyType: Array<String?>?,
Expand Down
Loading
Loading