fix: no-magic-number not working in array of widgets (#551)

* fix: no-magic-number not working in array of widgets

* test: add array testcase for no_magic_number rule

* test: add lint comments to array_example of no_magic_number test

* docs: add no_magic_number fix to CHANGELOG

* fix: codestyle in no-magic-number rule and test

* test: fix no-magic-number-rule-test for widget array

Author: HFabi

CHANGELOG.md

@@ -6,6 +6,7 @@
 * feat: add static code diagnostics `avoid-unnecessary-type-assertions`
 * refactor: cleanup anti-patterns, metrics and rules documentation
 * chore: activate self implemented rules: avoid-unnecessary-type-assertions, prefer-first, prefer-last, prefer-match-file-name
+* fix: no-magic-number not working in array of widgets
 
 ## 4.6.0
 

lib/src/analyzers/lint_analyzer/rules/rules_list/no_magic_number/no_magic_number_rule.dart

@@ -73,8 +73,7 @@ class NoMagicNumberRule extends CommonRule {
       ) ==
       null;
 
-  bool _isNotInsideCollectionLiteral(Literal l) =>
-      l.thisOrAncestorMatching((ancestor) => ancestor is TypedLiteral) == null;
+  bool _isNotInsideCollectionLiteral(Literal l) => l.parent is! TypedLiteral;
 
   bool _isNotInsideConstConstructor(Literal l) =>
       l.thisOrAncestorMatching((ancestor) =>

test/src/analyzers/lint_analyzer/rules/rules_list/no_magic_number/examples/array_example.dart

@@ -0,0 +1,16 @@
+class ContainerWidget {
+  int height;
+  List<ContainerWidget>? children;
+  ContainerWidget({required this.height, this.children});
+
+  ContainerWidget build() {
+    return ContainerWidget(
+      height: 83, // LINT
+      children: [
+        ContainerWidget(
+          height: 83, // LINT
+        ),
+      ],
+    );
+  }
+}

test/src/analyzers/lint_analyzer/rules/rules_list/no_magic_number/no_magic_number_rule_test.dart

@@ -9,6 +9,7 @@ const _examplePath = 'no_magic_number/examples/example.dart';
 const _incorrectExamplePath = 'no_magic_number/examples/incorrect_example.dart';
 const _exceptionsExamplePath =
     'no_magic_number/examples/exceptions_example.dart';
+const _arrayExamplePath = 'no_magic_number/examples/array_example.dart';
 
 void main() {
   group('NoMagicNumberRule', () {
@@ -61,5 +62,20 @@ void main() {
 
       RuleTestHelper.verifyNoIssues(issues);
     });
+
+    test('reports magic numbers in objects in widget array structures',
+        () async {
+      final unit = await RuleTestHelper.resolveFromFile(_arrayExamplePath);
+      final issues = NoMagicNumberRule().check(unit);
+
+      RuleTestHelper.verifyIssues(
+        issues: issues,
+        startOffsets: [202, 275],
+        startLines: [8, 11],
+        startColumns: [15, 19],
+        endOffsets: [204, 277],
+        locationTexts: ['83', '83'],
+      );
+    });
   });
 }