Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

Commit b5e9f39

Browse files
dkrutskikhdkrutskikh
authored
chore: activate some self implemented rules (#553)
* chore: activate prefer-first * chore: activate prefer-match-file-name * chore: activate prefer-last * chore: activate avoid-unnecessary-type-assertions * chore: update changelog
1 parent 020abd2 commit b5e9f39

File tree

150 files changed

+214
-202
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

150 files changed

+214
-202
lines changed

‎CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions

‎analysis_options.yaml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ dart_code_metrics:
3333
- test/*
3434
rules:
3535
- avoid-unused-parameters
36+
- avoid-unnecessary-type-assertions
3637
- binary-expression-operand-order
3738
- double-literal-format
3839
- newline-before-return
@@ -41,6 +42,11 @@ dart_code_metrics:
4142
- no-equal-then-else
4243
- no-object-declaration
4344
- prefer-conditional-expressions
45+
- prefer-first
46+
- prefer-last
47+
- prefer-match-file-name:
48+
exclude:
49+
- test/**
4450
- prefer-trailing-comma
4551

4652
linter:

‎lib/src/analyzer_plugin/analyzer_plugin.dart‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import '../config_builder/models/analysis_options.dart';
2424
import '../utils/yaml_utils.dart';
2525
import 'analyzer_plugin_utils.dart';
2626

27-
class MetricsAnalyzerPlugin extends ServerPlugin {
27+
class AnalyzerPlugin extends ServerPlugin {
2828
static const _analyzer = LintAnalyzer();
2929

3030
final _configs = <AnalysisDriverGeneric, LintAnalysisConfig>{};
@@ -44,7 +44,7 @@ class MetricsAnalyzerPlugin extends ServerPlugin {
4444
@override
4545
String get version => '1.0.0-alpha.0';
4646

47-
MetricsAnalyzerPlugin(ResourceProvider provider) : super(provider);
47+
AnalyzerPlugin(ResourceProvider provider) : super(provider);
4848

4949
@override
5050
void contentChanged(String path) {

‎lib/src/analyzer_plugin/analyzer_plugin_starter.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@ import 'package:analyzer_plugin/starter.dart';
66
import 'analyzer_plugin.dart';
77

88
void start(Iterable<String> _, SendPort sendPort) {
9-
ServerPluginStarter(MetricsAnalyzerPlugin(PhysicalResourceProvider.INSTANCE))
9+
ServerPluginStarter(AnalyzerPlugin(PhysicalResourceProvider.INSTANCE))
1010
.start(sendPort);
1111
}

‎lib/src/analyzers/lint_analyzer/reporters/reporters_list/html/lint_html_reporter.dart‎

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import 'dart:io';
33

44
import 'package:collection/collection.dart';
55
import 'package:html/dom.dart';
6-
import 'package:meta/meta.dart';
76
import 'package:path/path.dart' as p;
87

98
import '../../../../../reporters/models/html_reporter.dart';
@@ -14,7 +13,7 @@ import '../../../models/summary_lint_report_record.dart';
1413
import '../../utility_selector.dart';
1514
import 'components/icon.dart';
1615
import 'components/issue_details_tooltip.dart';
17-
import 'models/file_metrics_report.dart';
16+
import 'models/report_table_record.dart';
1817
import 'utility_functions.dart';
1918

2019
const _violationLevelFunctionStyle = {
@@ -47,21 +46,6 @@ const _maximumNestingWithViolations = '$_maximumNesting / violations';
4746
const _codeIssues = 'Issues';
4847
const _designIssues = 'Design issues';
4948

50-
/// A table record used by [LintHtmlReporter]
51-
@immutable
52-
class ReportTableRecord {
53-
final String title;
54-
final String link;
55-
56-
final FileMetricsReport report;
57-
58-
const ReportTableRecord({
59-
required this.title,
60-
required this.link,
61-
required this.report,
62-
});
63-
}
64-
6549
/// Lint HTML reporter.
6650
///
6751
/// Use it to create reports in HTML format.

‎lib/src/analyzers/lint_analyzer/reporters/reporters_list/html/models/report_table_record.dart‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
import 'package:meta/meta.dart';
2+
3+
import 'file_metrics_report.dart';
4+
5+
/// A table record
6+
///
7+
/// used by html reporter to represent file system entiry with accomulated metrics
8+
@immutable
9+
class ReportTableRecord {
10+
final String title;
11+
final String link;
12+
13+
final FileMetricsReport report;
14+
15+
const ReportTableRecord({
16+
required this.title,
17+
required this.link,
18+
required this.report,
19+
});
20+
}

‎lib/src/analyzers/lint_analyzer/reporters/reporters_list/html/utility_functions.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import 'package:html/dom.dart';
33
import '../../../models/report.dart';
44
import 'components/icon.dart';
55
import 'components/report_details_tooltip.dart';
6-
import 'lint_html_reporter.dart';
6+
import 'models/report_table_record.dart';
77

88
const _violations = 'violations';
99

‎lib/src/analyzers/lint_analyzer/rules/rules_factory.dart‎

Lines changed: 43 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,40 @@
11
import 'models/rule.dart';
2-
import 'rules_list/always_remove_listener/always_remove_listener.dart';
3-
import 'rules_list/avoid_ignoring_return_values/avoid_ignoring_return_values.dart';
4-
import 'rules_list/avoid_late_keyword/avoid_late_keyword.dart';
5-
import 'rules_list/avoid_nested_conditional_expressions/avoid_nested_conditional_expressions.dart';
6-
import 'rules_list/avoid_non_null_assertion/avoid_non_null_assertion.dart';
7-
import 'rules_list/avoid_preserve_whitespace_false/avoid_preserve_whitespace_false.dart';
8-
import 'rules_list/avoid_returning_widgets/avoid_returning_widgets.dart';
9-
import 'rules_list/avoid_unnecessary_setstate/avoid_unnecessary_setstate.dart';
10-
import 'rules_list/avoid_unnecessary_type_assertions/avoid_unnecessary_type_assertions.dart';
11-
import 'rules_list/avoid_unused_parameters/avoid_unused_parameters.dart';
12-
import 'rules_list/avoid_wrapping_in_padding/avoid_wrapping_in_padding.dart';
13-
import 'rules_list/binary_expression_operand_order/binary_expression_operand_order.dart';
14-
import 'rules_list/component_annotation_arguments_ordering/component_annotation_arguments_ordering.dart';
15-
import 'rules_list/double_literal_format/double_literal_format.dart';
16-
import 'rules_list/member_ordering/member_ordering.dart';
17-
import 'rules_list/member_ordering_extended/member_ordering_extended.dart';
18-
import 'rules_list/newline_before_return/newline_before_return.dart';
19-
import 'rules_list/no_boolean_literal_compare/no_boolean_literal_compare.dart';
20-
import 'rules_list/no_empty_block/no_empty_block.dart';
21-
import 'rules_list/no_equal_arguments/no_equal_arguments.dart';
22-
import 'rules_list/no_equal_then_else/no_equal_then_else.dart';
23-
import 'rules_list/no_magic_number/no_magic_number.dart';
24-
import 'rules_list/no_object_declaration/no_object_declaration.dart';
25-
import 'rules_list/prefer_conditional_expressions/prefer_conditional_expressions.dart';
26-
import 'rules_list/prefer_const_border_radius/prefer_const_border_radius.dart';
27-
import 'rules_list/prefer_correct_identifier_length/prefer_correct_identifier_length.dart';
28-
import 'rules_list/prefer_correct_type_name/prefer_correct_type_name.dart';
29-
import 'rules_list/prefer_extracting_callbacks/prefer_extracting_callbacks.dart';
30-
import 'rules_list/prefer_first/prefer_first.dart';
31-
import 'rules_list/prefer_intl_name/prefer_intl_name.dart';
32-
import 'rules_list/prefer_last/prefer_last.dart';
33-
import 'rules_list/prefer_match_file_name/prefer_match_file_name.dart';
34-
import 'rules_list/prefer_on_push_cd_strategy/prefer_on_push_cd_strategy.dart';
35-
import 'rules_list/prefer_single_widget_per_file/prefer_single_widget_per_file.dart';
36-
import 'rules_list/prefer_trailing_comma/prefer_trailing_comma.dart';
37-
import 'rules_list/provide_correct_intl_args/provide_correct_intl_args.dart';
2+
import 'rules_list/always_remove_listener/always_remove_listener_rule.dart';
3+
import 'rules_list/avoid_ignoring_return_values/avoid_ignoring_return_values_rule.dart';
4+
import 'rules_list/avoid_late_keyword/avoid_late_keyword_rule.dart';
5+
import 'rules_list/avoid_nested_conditional_expressions/avoid_nested_conditional_expressions_rule.dart';
6+
import 'rules_list/avoid_non_null_assertion/avoid_non_null_assertion_rule.dart';
7+
import 'rules_list/avoid_preserve_whitespace_false/avoid_preserve_whitespace_false_rule.dart';
8+
import 'rules_list/avoid_returning_widgets/avoid_returning_widgets_rule.dart';
9+
import 'rules_list/avoid_unnecessary_setstate/avoid_unnecessary_setstate_rule.dart';
10+
import 'rules_list/avoid_unnecessary_type_assertions/avoid_unnecessary_type_assertions_rule.dart';
11+
import 'rules_list/avoid_unused_parameters/avoid_unused_parameters_rule.dart';
12+
import 'rules_list/avoid_wrapping_in_padding/avoid_wrapping_in_padding_rule.dart';
13+
import 'rules_list/binary_expression_operand_order/binary_expression_operand_order_rule.dart';
14+
import 'rules_list/component_annotation_arguments_ordering/component_annotation_arguments_ordering_rule.dart';
15+
import 'rules_list/double_literal_format/double_literal_format_rule.dart';
16+
import 'rules_list/member_ordering/member_ordering_rule.dart';
17+
import 'rules_list/member_ordering_extended/member_ordering_extended_rule.dart';
18+
import 'rules_list/newline_before_return/newline_before_return_rule.dart';
19+
import 'rules_list/no_boolean_literal_compare/no_boolean_literal_compare_rule.dart';
20+
import 'rules_list/no_empty_block/no_empty_block_rule.dart';
21+
import 'rules_list/no_equal_arguments/no_equal_arguments_rule.dart';
22+
import 'rules_list/no_equal_then_else/no_equal_then_else_rule.dart';
23+
import 'rules_list/no_magic_number/no_magic_number_rule.dart';
24+
import 'rules_list/no_object_declaration/no_object_declaration_rule.dart';
25+
import 'rules_list/prefer_conditional_expressions/prefer_conditional_expressions_rule.dart';
26+
import 'rules_list/prefer_const_border_radius/prefer_const_border_radius_rule.dart';
27+
import 'rules_list/prefer_correct_identifier_length/prefer_correct_identifier_length_rule.dart';
28+
import 'rules_list/prefer_correct_type_name/prefer_correct_type_name_rule.dart';
29+
import 'rules_list/prefer_extracting_callbacks/prefer_extracting_callbacks_rule.dart';
30+
import 'rules_list/prefer_first/prefer_first_rule.dart';
31+
import 'rules_list/prefer_intl_name/prefer_intl_name_rule.dart';
32+
import 'rules_list/prefer_last/prefer_last_rule.dart';
33+
import 'rules_list/prefer_match_file_name/prefer_match_file_name_rule.dart';
34+
import 'rules_list/prefer_on_push_cd_strategy/prefer_on_push_cd_strategy_rule.dart';
35+
import 'rules_list/prefer_single_widget_per_file/prefer_single_widget_per_file_rule.dart';
36+
import 'rules_list/prefer_trailing_comma/prefer_trailing_comma_rule.dart';
37+
import 'rules_list/provide_correct_intl_args/provide_correct_intl_args_rule.dart';
3838

3939
final _implementedRules = <String, Rule Function(Map<String, Object>)>{
4040
AlwaysRemoveListenerRule.ruleId: (config) => AlwaysRemoveListenerRule(config),
@@ -51,8 +51,8 @@ final _implementedRules = <String, Rule Function(Map<String, Object>)>{
5151
AvoidReturningWidgetsRule(config),
5252
AvoidUnnecessarySetStateRule.ruleId: (config) =>
5353
AvoidUnnecessarySetStateRule(config),
54-
AvoidUnnecessaryTypeAssertions.ruleId: (config) =>
55-
AvoidUnnecessaryTypeAssertions(config),
54+
AvoidUnnecessaryTypeAssertionsRule.ruleId: (config) =>
55+
AvoidUnnecessaryTypeAssertionsRule(config),
5656
AvoidUnusedParametersRule.ruleId: (config) =>
5757
AvoidUnusedParametersRule(config),
5858
AvoidWrappingInPaddingRule.ruleId: (config) =>
@@ -77,15 +77,16 @@ final _implementedRules = <String, Rule Function(Map<String, Object>)>{
7777
PreferConditionalExpressionsRule(config),
7878
PreferConstBorderRadiusRule.ruleId: (config) =>
7979
PreferConstBorderRadiusRule(config),
80-
PreferCorrectIdentifierLength.ruleId: (config) =>
81-
PreferCorrectIdentifierLength(config),
82-
PreferCorrectTypeName.ruleId: (config) => PreferCorrectTypeName(config),
80+
PreferCorrectIdentifierLengthRule.ruleId: (config) =>
81+
PreferCorrectIdentifierLengthRule(config),
82+
PreferCorrectTypeNameRule.ruleId: (config) =>
83+
PreferCorrectTypeNameRule(config),
8384
PreferExtractingCallbacksRule.ruleId: (config) =>
8485
PreferExtractingCallbacksRule(config),
8586
PreferFirstRule.ruleId: (config) => PreferFirstRule(config),
8687
PreferIntlNameRule.ruleId: (config) => PreferIntlNameRule(config),
8788
PreferLastRule.ruleId: (config) => PreferLastRule(config),
88-
PreferMatchFileName.ruleId: (config) => PreferMatchFileName(config),
89+
PreferMatchFileNameRule.ruleId: (config) => PreferMatchFileNameRule(config),
8990
PreferOnPushCdStrategyRule.ruleId: (config) =>
9091
PreferOnPushCdStrategyRule(config),
9192
PreferSingleWidgetPerFileRule.ruleId: (config) =>

‎lib/src/analyzers/lint_analyzer/rules/rules_list/always_remove_listener/always_remove_listener.dart‎ renamed to ‎lib/src/analyzers/lint_analyzer/rules/rules_list/always_remove_listener/always_remove_listener_rule.dart‎

File renamed without changes.

‎lib/src/analyzers/lint_analyzer/rules/rules_list/always_remove_listener/visitor.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
part of 'always_remove_listener.dart';
1+
part of 'always_remove_listener_rule.dart';
22

33
class _Visitor extends RecursiveAstVisitor<void> {
44
final _missingInvocations = <MethodInvocation>[];

0 commit comments

Comments
 (0)