fix: correcly handle const maps (#692)

* fix: correcly handle const maps

* chore: leftovers

* chore: update changelog

Author: incendial

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Unreleased
 
 * chore: activate new lint rules.
+* fix: correctly handle const maps in `no-magic-number`.
 
 ## 4.11.0-dev.1
 

lib/src/analyzers/lint_analyzer/rules/rules_list/no_magic_number/no_magic_number_rule.dart

@@ -40,6 +40,7 @@ class NoMagicNumberRule extends CommonRule {
         .where(_isMagicNumber)
         .where(_isNotInsideVariable)
         .where(_isNotInsideCollectionLiteral)
+        .where(_isNotInsideConstMap)
         .where(_isNotInsideConstConstructor)
         .where(_isNotInDateTime)
         .map((lit) => createIssue(
@@ -75,6 +76,12 @@ class NoMagicNumberRule extends CommonRule {
 
   bool _isNotInsideCollectionLiteral(Literal l) => l.parent is! TypedLiteral;
 
+  bool _isNotInsideConstMap(Literal l) {
+    final grandParent = l.parent?.parent;
+
+    return !(grandParent is SetOrMapLiteral && grandParent.isConst);
+  }
+
   bool _isNotInsideConstConstructor(Literal l) =>
       l.thisOrAncestorMatching((ancestor) =>
           ancestor is InstanceCreationExpression && ancestor.isConst) ==

test/src/analyzers/lint_analyzer/rules/rules_list/no_magic_number/examples/example.dart

@@ -2,5 +2,17 @@ const pi = 3.14;
 const pi2 = pi * 2;
 const str = 'Hello';
 
-void good_f4(int x) => a * pi;
-void good_f5() => good_f4(pi2);
+void fun1(int x) => a * pi;
+void fun2() => fun1(pi2);
+void fun3() => const {
+      'Key.a': 0.1,
+      'Key.b': 0.1,
+      'Key.c': 0.1,
+    };
+void fun4() {
+  return const {1, 2};
+}
+
+void fun5() => const {1, 2};
+
+void fun6() => const Map<String, String>();