chore: activate new lint rules (#689)

* chore: activate new linter rules

* chore: activate new lint rules.

* chore: disable some lint rules for dart 2.14

* chore: update tests

Author: dkrutskikh

.github/workflows/package_analyze.yaml

@@ -127,7 +127,13 @@ jobs:
 
       - name: Disable unsupported rules
         run: |
-          sed -i'.original' 's/- unnecessary_constructor_name/#    - unnecessary_constructor_name/g' analysis_options.yaml
+          sed -i'.original' 's/- avoid_final_parameters/#                       - avoid_final_parameters/g' analysis_options.yaml
+          sed -i'.original' 's/- conditional_uri_does_not_exist/#               - conditional_uri_does_not_exist/g' analysis_options.yaml
+          sed -i'.original' 's/- no_leading_underscores_for_library_prefixes/#  - no_leading_underscores_for_library_prefixes/g' analysis_options.yaml
+          sed -i'.original' 's/- no_leading_underscores_for_local_identifiers/# - no_leading_underscores_for_local_identifiers/g' analysis_options.yaml
+          sed -i'.original' 's/- secure_pubspec_urls/#                          - secure_pubspec_urls/g' analysis_options.yaml
+          sed -i'.original' 's/- unnecessary_constructor_name/#                 - unnecessary_constructor_name/g' analysis_options.yaml
+          sed -i'.original' 's/- unnecessary_late/#                             - unnecessary_late/g' analysis_options.yaml
 
       - name: Check compatibility
         run: |

CHANGELOG.md

@@ -1,9 +1,13 @@
 # Changelog
 
+## Unreleased
+
+* chore: activate new lint rules.
+
 ## 4.11.0-dev.1
 
 * fix: move byte store out of driver creation to reuse it between multiple plugins.
-* fix: add `monorepo` flag for `check-unused-code` command.
+* fix: add `monorepo` flag for `check-unused-files` command.
 * fix: ignore a class usage inside `State<T>` for `check-unused-code` command.
 * fix: correctly handle variables declaration for `check-unused-code` command.
 * feat: add static code diagnostics `avoid-dynamic`, `prefer-async-await`.

analysis_options.yaml

@@ -45,19 +45,30 @@ dart_code_metrics:
     - test/resources/*
     - test/*
   rules:
+    - avoid-dynamic:
+        exclude:
+          - test/**
     - avoid-global-state
-    - avoid-unused-parameters
+    - avoid-late-keyword:
+        exclude:
+          - test/**
+    - avoid-missing-enum-constant-in-map
     - avoid-unnecessary-type-assertions
     - avoid-unnecessary-type-casts
-    - avoid-global-state
+    - avoid-unused-parameters
     - binary-expression-operand-order
     - double-literal-format
     - newline-before-return
     - no-boolean-literal-compare
     - no-empty-block
     - no-equal-then-else
     - no-object-declaration
+    - prefer-async-await
     - prefer-conditional-expressions
+    - prefer-correct-identifier-length:
+        exceptions:
+          - id
+          - ok
     - prefer-correct-type-name
     - prefer-first
     - prefer-last
@@ -83,6 +94,7 @@ linter:
     - avoid_equals_and_hash_code_on_mutable_classes
     - avoid_escaping_inner_quotes
     - avoid_field_initializers_in_const_classes
+    - avoid_final_parameters
     - avoid_implementing_value_types
     - avoid_js_rounded_ints
     - avoid_multiple_declarations_per_line
@@ -106,6 +118,7 @@ linter:
     #    - cast_nullable_to_non_nullable
     - close_sinks
     - comment_references
+    - conditional_uri_does_not_exist
     - depend_on_referenced_packages
     - deprecated_consistency
     - diagnostic_describe_all_properties
@@ -122,6 +135,8 @@ linter:
     - missing_whitespace_between_adjacent_strings
     #    - no_adjacent_strings_in_list
     - no_default_cases
+    - no_leading_underscores_for_library_prefixes
+    - no_leading_underscores_for_local_identifiers
     - no_logic_in_create_state
     - no_runtimeType_toString
     - noop_primitive_operations
@@ -153,7 +168,9 @@ linter:
     - prefer_single_quotes
     #    - public_member_api_docs
     #    - require_trailing_commas
-    - sized_box_for_whitespace
+    - secure_pubspec_urls
+    #    - sized_box_for_whitespace
+    #    - sized_box_shrink_expand
     #    - sort_child_properties_last
     #    - sort_constructors_first
     - sort_pub_dependencies
@@ -167,14 +184,16 @@ linter:
     - unnecessary_constructor_name
     #    - unnecessary_final
     - unnecessary_lambdas
+    - unnecessary_late
     - unnecessary_null_aware_assignments
     - unnecessary_null_checks
     - unnecessary_nullable_for_final_variable_declarations
     - unnecessary_parenthesis
     - unnecessary_raw_strings
     - unnecessary_statements
     - unsafe_html
-    - use_build_context_synchronously
+    #    - use_build_context_synchronously
+    #    - use_decorated_box
     #    - use_full_hex_values_for_flutter_colors
     - use_if_null_to_convert_nulls_to_bools
     - use_is_even_rather_than_modulo

lib/src/analyzers/lint_analyzer/lint_config.dart

@@ -23,17 +23,17 @@ class LintConfig {
 
   /// Creates the config from analysis [options].
   factory LintConfig.fromAnalysisOptions(AnalysisOptions options) {
-    const _rootKey = 'dart_code_metrics';
+    const rootKey = 'dart_code_metrics';
 
     return LintConfig(
       excludePatterns: options.readIterableOfString(['analyzer', 'exclude']),
       excludeForMetricsPatterns:
-          options.readIterableOfString([_rootKey, 'metrics-exclude']),
-      metrics: options.readMap([_rootKey, 'metrics']),
-      rules: options.readMapOfMap([_rootKey, 'rules']),
+          options.readIterableOfString([rootKey, 'metrics-exclude']),
+      metrics: options.readMap([rootKey, 'metrics']),
+      rules: options.readMapOfMap([rootKey, 'rules']),
       excludeForRulesPatterns:
-          options.readIterableOfString([_rootKey, 'rules-exclude']),
-      antiPatterns: options.readMapOfMap([_rootKey, 'anti-patterns']),
+          options.readIterableOfString([rootKey, 'rules-exclude']),
+      antiPatterns: options.readMapOfMap([rootKey, 'anti-patterns']),
     );
   }
 

lib/src/analyzers/lint_analyzer/metrics/metric_utils.dart

@@ -82,11 +82,11 @@ bool isReportLevel(MetricValueLevel level) =>
 
 /// Returns user friendly string representations of [type].
 String userFriendlyType(Type type) {
-  const _impl = 'Impl';
+  const impl = 'Impl';
 
   final typeName = type.toString();
 
-  return typeName.endsWith(_impl)
-      ? typeName.substring(0, typeName.length - _impl.length)
+  return typeName.endsWith(impl)
+      ? typeName.substring(0, typeName.length - impl.length)
       : typeName;
 }

lib/src/analyzers/lint_analyzer/metrics/metrics_factory.dart

@@ -39,15 +39,15 @@ Iterable<Metric> getMetrics({
   Iterable<String> patternsDependencies = const [],
   EntityType? measuredType,
 }) {
-  final _metrics = _implementedMetrics.keys.map(
+  final metrics = _implementedMetrics.keys.map(
     (id) => _implementedMetrics[id]!(
       !patternsDependencies.contains(id) ? config : {},
     ),
   );
 
   return measuredType != null
-      ? _metrics
+      ? metrics
           .where((metric) => metric.documentation.measuredType == measuredType)
           .toList()
-      : _metrics;
+      : metrics;
 }

lib/src/analyzers/lint_analyzer/metrics/metrics_list/cyclomatic_complexity/cyclomatic_complexity_metric.dart

@@ -70,15 +70,16 @@ class CyclomaticComplexityMetric extends FunctionMetric<int> {
     InternalResolvedUnitResult source,
   ) =>
       complexityEntities.map((entity) {
-        late String message;
+        String? message;
+
         if (entity is AstNode) {
           message = userFriendlyType(entity.runtimeType).camelCaseToText();
         } else if (entity is Token) {
           message = 'Operator ${entity.lexeme}';
         }
 
         return ContextMessage(
-          message: '${message.capitalize()} increases complexity',
+          message: '${message?.capitalize()} increases complexity',
           location: nodeLocation(node: entity, source: source),
         );
       }).toList()

lib/src/analyzers/lint_analyzer/metrics/metrics_list/weight_of_class_metric.dart

@@ -89,13 +89,13 @@ class WeightOfClassMetric extends ClassMetric<double> {
       !Identifier.isPrivateName(function.name);
 
   bool _isFunctionalMethod(ScopedFunctionDeclaration function) {
-    const _nonFunctionalTypes = {
+    const nonFunctionalTypes = {
       FunctionType.constructor,
       FunctionType.setter,
       FunctionType.getter,
     };
 
-    return !_nonFunctionalTypes.contains(function.type);
+    return !nonFunctionalTypes.contains(function.type);
   }
 
   Iterable<ContextMessage> _context(

lib/src/analyzers/lint_analyzer/reporters/reporters_list/html/lint_html_reporter.dart

@@ -333,40 +333,41 @@ class LintHtmlReporter extends HtmlReporter<LintFileReport,
 
     final linesIndices = Element.tag('td')
       ..classes.add('metrics-source-code__number-lines');
-    for (var i = 1; i <= sourceFileLines.length; ++i) {
+    for (var lineIndex = 1; lineIndex <= sourceFileLines.length; ++lineIndex) {
       linesIndices
-        ..append(Element.tag('a')..attributes['name'] = 'L$i')
+        ..append(Element.tag('a')..attributes['name'] = 'L$lineIndex')
         ..append(Element.tag('a')
           ..classes.add('metrics-source-code__number')
-          ..attributes['href'] = '#L$i'
-          ..text = '$i')
+          ..attributes['href'] = '#L$lineIndex'
+          ..text = '$lineIndex')
         ..append(Element.tag('br'));
     }
 
     final cyclomaticValues = Element.tag('td')
       ..classes.add('metrics-source-code__complexity');
-    for (var i = 1; i <= sourceFileLines.length; ++i) {
+    for (var lineIndex = 1; lineIndex <= sourceFileLines.length; ++lineIndex) {
       final complexityValueElement = Element.tag('div')
         ..classes.add('metrics-source-code__text');
 
       final classReport = record.classes.entries.firstWhereOrNull((report) =>
-          report.value.location.start.line <= i &&
-          report.value.location.end.line >= i);
-      if (classReport != null && classReport.value.location.start.line == i) {
+          report.value.location.start.line <= lineIndex &&
+          report.value.location.end.line >= lineIndex);
+      if (classReport != null &&
+          classReport.value.location.start.line == lineIndex) {
         complexityValueElement
           ..classes.add('metrics-source-code__text--with-icon')
           ..append(renderComplexityIcon(classReport.value, classReport.key));
       }
 
       final functionReport = record.functions.entries.firstWhereOrNull(
         (report) =>
-            report.value.location.start.line <= i &&
-            report.value.location.end.line >= i,
+            report.value.location.start.line <= lineIndex &&
+            report.value.location.end.line >= lineIndex,
       );
 
       var line = '';
       if (functionReport != null) {
-        if (functionReport.value.location.start.line == i) {
+        if (functionReport.value.location.start.line == lineIndex) {
           complexityValueElement
             ..classes.add('metrics-source-code__text--with-icon')
             ..append(
@@ -377,7 +378,7 @@ class LintHtmlReporter extends HtmlReporter<LintFileReport,
         final lineWithComplexityIncrement = functionReport.value
                 .metric(CyclomaticComplexityMetric.metricId)
                 ?.context
-                .where((element) => element.location.start.line == i)
+                .where((element) => element.location.start.line == lineIndex)
                 .length ??
             0;
 
@@ -403,7 +404,9 @@ class LintHtmlReporter extends HtmlReporter<LintFileReport,
       final debt = record.file
           .metric(TechnicalDebtMetric.metricId)
           ?.context
-          .firstWhereOrNull((context) => context.location.start.line == i)
+          .firstWhereOrNull(
+            (context) => context.location.start.line == lineIndex,
+          )
           ?.message;
       if (debt != null) {
         line += debt;
@@ -414,8 +417,9 @@ class LintHtmlReporter extends HtmlReporter<LintFileReport,
         complexityValueElement.text = line.replaceAll(' ', '&nbsp;');
       }
 
-      final architecturalIssues = record.antiPatternCases
-          .firstWhereOrNull((element) => element.location.start.line == i);
+      final architecturalIssues = record.antiPatternCases.firstWhereOrNull(
+        (element) => element.location.start.line == lineIndex,
+      );
 
       if (architecturalIssues != null) {
         final issueIcon = Element.tag('div')

lib/src/analyzers/lint_analyzer/rules/rules_list/always_remove_listener/always_remove_listener_rule.dart

@@ -32,11 +32,11 @@ class AlwaysRemoveListenerRule extends FlutterRule {
 
   @override
   Iterable<Issue> check(InternalResolvedUnitResult source) {
-    final _visitor = _Visitor();
+    final visitor = _Visitor();
 
-    source.unit.visitChildren(_visitor);
+    source.unit.visitChildren(visitor);
 
-    return _visitor.missingInvocations
+    return visitor.missingInvocations
         .map((invocation) => createIssue(
               rule: this,
               location: nodeLocation(