Skip to content

Fix comparison with nan #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2022
Merged

Fix comparison with nan #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f7307c
Fix comparision with nan
Gobot1234 Apr 11, 2022
9e88585
Update src/betterproto/__init__.py
Gobot1234 Apr 22, 2022
757cdec
Quick sneaky update pre-commit version
Gobot1234 Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ repos:
- id: isort

- repo: https://github.com/psf/black
rev: 22.1.0
rev: 22.3.0
hooks:
- id: black

Expand Down
9 changes: 4 additions & 5 deletions src/betterproto/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ def _parse_float(value: Any) -> float:

Parameters
----------
value : Any
value: Any
Value to parse

Returns
Expand All @@ -455,20 +455,19 @@ def _dump_float(value: float) -> Union[float, str]:

Parameters
----------
value : float
value: float
Value to dump

Returns
-------
Union[float, str]
Dumped valid, either a float or the strings
"Infinity" or "-Infinity"
Dumped value, either a float or the strings
"""
if value == float("inf"):
return INFINITY
if value == -float("inf"):
return NEG_INFINITY
if value == float("nan"):
if isinstance(value, float) and math.isnan(value):
return NAN
return value

Expand Down