Skip to content

Conversation

@0xgouda
Copy link
Collaborator

@0xgouda 0xgouda commented Dec 2, 2025

The lines below in the Shard Buffers hit pct panel in the 0. Health Check dashboard are unnecessary and decrease query performance:

(data->>'xact_rollback')::int8 as roll, lag((data->>'xact_rollback')::int8) over w as roll_lag,
(data->>'xact_commit')::int8 as comm, lag((data->>'xact_commit')::int8) over w as comm_lag,

It seems the query was copied as is from TX rollback pct, and those weren't removed.

@0xgouda 0xgouda added enhancement New feature or request dashboards Grafana dashboards related labels Dec 2, 2025
@0xgouda 0xgouda self-assigned this Dec 2, 2025
@0xgouda 0xgouda requested a review from pashagolub December 2, 2025 11:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19856710985

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.648%

Totals Coverage Status
Change from base Build 19825348195: 0.0%
Covered Lines: 3678
Relevant Lines: 4994

💛 - Coveralls

@0xgouda 0xgouda changed the title [-] fix sql of Shared Buffers hit pct panel. [-] fix sql of Shared Buffers hit pct panel Dec 2, 2025
Copy link
Collaborator

@pashagolub pashagolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@pashagolub pashagolub merged commit 0cba351 into cybertec-postgresql:master Dec 3, 2025
5 checks passed
@pashagolub pashagolub added refactoring Something done as it should've been done from the start and removed enhancement New feature or request labels Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dashboards Grafana dashboards related refactoring Something done as it should've been done from the start

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants