[-] migrate all panels in 0. Health Check dashboard to table format
#1057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to use additional `$online_interval` variable, we can directly use `$__timeFilter(time)` to get data only from the time range used by users. - `select 0 as time` and `select time` blocks are removed. - `$__timeGroup($online_inteval` blocks are removed, as data is already within the chosen time range no need for further grouping by time. - `where time > now() - '$online_interval'::interval` are substituted with `$__timeFilter(time)`.
Pull Request Test Coverage Report for Build 19863725599Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
0xgouda
added
enhancement
0xgouda
changed the title
0. Health Check dashboard to table format.0. Health Check dashboard to table format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$online_intervalvariable.table format.time seriesformat:select 0 as time, ....0 as timeand usetable formatinstead.select time, .....select $__timeGroup(time, $online_interval) .... group by 1.$__timeFilter(time), so any further time grouping is not required, but actually can make the result imprecise, as some data that should be shown might fall into a different group that will be ignored.where time > now() - '$online_interval'::intervaland use$__timeFilter(time)instead.TODO: