Skip to content

Practice code review with coding partner #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Practice code review with coding partner #1

wants to merge 2 commits into from

Conversation

@cwaku
Copy link
Owner

@cwaku cwaku commented Dec 7, 2021

All projects requirements are met. Please do review my code if you have time

@tongoonamujera
Copy link
Collaborator

tongoonamujera commented Dec 7, 2021 •
edited by cwaku
Loading

  • Nice to have a working codebase
  • Nice to have a dry code
  • It will be more nice to move your todo list logic to seperate files from index.js
  • Its nice to add some methods into seperate files with which you can call these class methods inside your index.js

@cwaku cwaku requested a review from tongoonamujera December 7, 2021 14:14
@tongoonamujera
Copy link
Collaborator

tongoonamujera commented Dec 7, 2021 •
edited
Loading

great work man

@cwaku
Copy link
Owner Author

cwaku commented Dec 8, 2021

great work man

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tongoonamujera tongoonamujera tongoonamujera approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cwaku @tongoonamujera