Skip to content

Conversation

@mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Nov 6, 2025

🤔 What's changed?

While the empty tag expression, results in a True expression. This
True expression should be rendered as the empty string to make it
possible to parse the string representation of a parsed expression.

⚡️ What's your motivation?

Fixes: #195

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@mpkorstanje mpkorstanje changed the title Use the empty string to represent the true expression Render the empty tag expression as the empty string Nov 7, 2025
@mpkorstanje mpkorstanje changed the title Render the empty tag expression as the empty string Render the empty tag expression as an empty string Nov 7, 2025
@mpkorstanje mpkorstanje marked this pull request as ready for review November 7, 2025 18:42
@mpkorstanje mpkorstanje mentioned this pull request Nov 7, 2025
7 tasks
@mpkorstanje mpkorstanje merged commit 8019694 into main Nov 9, 2025
43 checks passed
@mpkorstanje mpkorstanje deleted the fix/195-true-is-empty branch November 9, 2025 16:38
clrudolphi added a commit that referenced this pull request Nov 9, 2025
…ken ToString() should be empty string rather than "true").
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handling of the true expression is inconsistent

2 participants