Use Java 17 #352
Draft
Use Java 17 #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, messages are a bit cumbersome to use in combination with Java. The generated code currently uses long values where Java would use integers. This leads to some silly code: ```java lines.add((int) (long) location.getLine()); ``` Unfortunately, long values are needed for the timestamp and duration. So simply replacing longs with integers wouldn't work. By specifying some upper bounds the code generation can make a more informed choice about the size of number to use. The choice for 2^31 - 1 is somewhat arbitrary but matches the maximum length of strings in Java and .Net. In practice, I would expect Gherkin documents to have a much more reasonable length though.
# Conflicts: # jsonschema/src/Attachment.json # jsonschema/src/Duration.json # jsonschema/src/GherkinDocument.json # jsonschema/src/Meta.json # jsonschema/src/Pickle.json # jsonschema/src/Source.json # jsonschema/src/SourceReference.json # jsonschema/src/TestCase.json # jsonschema/src/TestCaseStarted.json # jsonschema/src/Timestamp.json # perl/lib/Cucumber/Messages.pm # python/src/cucumber_messages/_messages.py # ruby/lib/cucumber/messages/attachment.rb # ruby/lib/cucumber/messages/gherkin_document.rb # ruby/lib/cucumber/messages/meta.rb # ruby/lib/cucumber/messages/pickle.rb # ruby/lib/cucumber/messages/source.rb # ruby/lib/cucumber/messages/source_reference.rb # ruby/lib/cucumber/messages/step_match_argument.rb # ruby/lib/cucumber/messages/test_case_started.rb # ruby/lib/cucumber/messages/test_step.rb
* Set default release version to 17 * Enable Error prone with Nullaway
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
⚡️ What's your motivation?
🏷️ What kind of change is this?
📋 Checklist:
Listparameters #282