Skip to content

Use JUnit 6 ParallelHierarchicalTestExecutorServiceFactory #3105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Draft

Use JUnit 6 ParallelHierarchicalTestExecutorServiceFactory #3105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cucumber-junit-platform-engine/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<properties>
<hamcrest.version>3.0</hamcrest.version>
<junit-jupiter.version>5.14.0</junit-jupiter.version>
<junit-jupiter.version>6.1.0-SNAPSHOT</junit-jupiter.version>
</properties>

<dependencyManagement>
Expand Down
4 changes: 2 additions & 2 deletions ...t-platform-engine/src/main/java/io/cucumber/junit/platform/engine/CucumberTestEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
import org.junit.platform.engine.support.config.PrefixedConfigurationParameters;
import org.junit.platform.engine.support.descriptor.ClassSource;
import org.junit.platform.engine.support.discovery.DiscoveryIssueReporter;
import org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService;
import org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine;
import org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutorService;
import org.junit.platform.engine.support.hierarchical.ParallelHierarchicalTestExecutorServiceFactory;

import static io.cucumber.junit.platform.engine.Constants.FEATURES_PROPERTY_NAME;
import static io.cucumber.junit.platform.engine.Constants.JUNIT_PLATFORM_DISCOVERY_AS_ROOT_ENGINE_PROPERTY_NAME;
Expand Down Expand Up @@ -92,7 +92,7 @@ private static TestSource createEngineTestSource(ConfigurationParameters configu
protected HierarchicalTestExecutorService createExecutorService(ExecutionRequest request) {
CucumberConfiguration configuration = getCucumberConfiguration(request);
if (configuration.isParallelExecutionEnabled()) {
return new ForkJoinPoolHierarchicalTestExecutorService(
return ParallelHierarchicalTestExecutorServiceFactory.create(
new PrefixedConfigurationParameters(request.getConfigurationParameters(), PARALLEL_CONFIG_PREFIX));
}
return super.createExecutorService(request);
Expand Down