Skip to content

Commit cccbe3d

Browse files
author
Maxim Levitsky
committed
KVM: x86: Introduce supported_quirks to block disabling quirks
JIRA: https://issues.redhat.com/browse/RHEL-47242 commit bd7d536 Author: Yan Zhao <yan.y.zhao@intel.com> Date: Mon Feb 24 15:08:32 2025 +0800 KVM: x86: Introduce supported_quirks to block disabling quirks Introduce supported_quirks in kvm_caps to store platform-specific force-enabled quirks. No functional changes intended. Signed-off-by: Yan Zhao <yan.y.zhao@intel.com> Message-ID: <20250224070832.31394-1-yan.y.zhao@intel.com> [Remove unsupported quirks at KVM_ENABLE_CAP time. - Paolo] Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
1 parent 86b9b37 commit cccbe3d

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

arch/x86/kvm/x86.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4807,7 +4807,7 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
48074807
r = enable_pmu ? KVM_CAP_PMU_VALID_MASK : 0;
48084808
break;
48094809
case KVM_CAP_DISABLE_QUIRKS2:
4810-
r = KVM_X86_VALID_QUIRKS;
4810+
r = kvm_caps.supported_quirks;
48114811
break;
48124812
case KVM_CAP_X86_NOTIFY_VMEXIT:
48134813
r = kvm_caps.has_notify_vmexit;
@@ -6546,11 +6546,11 @@ int kvm_vm_ioctl_enable_cap(struct kvm *kvm,
65466546
switch (cap->cap) {
65476547
case KVM_CAP_DISABLE_QUIRKS2:
65486548
r = -EINVAL;
6549-
if (cap->args[0] & ~KVM_X86_VALID_QUIRKS)
6549+
if (cap->args[0] & ~kvm_caps.supported_quirks)
65506550
break;
65516551
fallthrough;
65526552
case KVM_CAP_DISABLE_QUIRKS:
6553-
kvm->arch.disabled_quirks |= cap->args[0];
6553+
kvm->arch.disabled_quirks |= cap->args[0] & kvm_caps.supported_quirks;
65546554
r = 0;
65556555
break;
65566556
case KVM_CAP_SPLIT_IRQCHIP: {
@@ -9792,6 +9792,7 @@ int kvm_x86_vendor_init(struct kvm_x86_init_ops *ops)
97929792
kvm_host.xcr0 = xgetbv(XCR_XFEATURE_ENABLED_MASK);
97939793
kvm_caps.supported_xcr0 = kvm_host.xcr0 & KVM_SUPPORTED_XCR0;
97949794
}
9795+
kvm_caps.supported_quirks = KVM_X86_VALID_QUIRKS;
97959796
kvm_caps.inapplicable_quirks = KVM_X86_CONDITIONAL_QUIRKS;
97969797

97979798
rdmsrl_safe(MSR_EFER, &kvm_host.efer);
@@ -12748,7 +12749,7 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type)
1274812749
/* Decided by the vendor code for other VM types. */
1274912750
kvm->arch.pre_fault_allowed =
1275012751
type == KVM_X86_DEFAULT_VM || type == KVM_X86_SW_PROTECTED_VM;
12751-
kvm->arch.disabled_quirks = kvm_caps.inapplicable_quirks;
12752+
kvm->arch.disabled_quirks = kvm_caps.inapplicable_quirks & kvm_caps.supported_quirks;
1275212753

1275312754
ret = kvm_page_track_init(kvm);
1275412755
if (ret)

arch/x86/kvm/x86.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ struct kvm_caps {
3434
u64 supported_xcr0;
3535
u64 supported_xss;
3636
u64 supported_perf_cap;
37+
38+
u64 supported_quirks;
3739
u64 inapplicable_quirks;
3840
};
3941

0 commit comments

Comments
 (0)