net: phy: dp83869: fix memory corruption when enabling fiber

JIRA: https://issues.redhat.com/browse/RHEL-57766

commit a842e44
Author: Ingo van Lil <inguin@gmx.de>
Date:   Wed Oct 2 18:18:07 2024 +0200

    net: phy: dp83869: fix memory corruption when enabling fiber

    When configuring the fiber port, the DP83869 PHY driver incorrectly
    calls linkmode_set_bit() with a bit mask (1 << 10) rather than a bit
    number (10). This corrupts some other memory location -- in case of
    arm64 the priv pointer in the same structure.

    Since the advertising flags are updated from supported at the end of the
    function the incorrect line isn't needed at all and can be removed.

    Fixes: a29de52 ("net: dp83869: Add ability to advertise Fiber connection")
    Signed-off-by: Ingo van Lil <inguin@gmx.de>
    Reviewed-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
    Reviewed-by: Andrew Lunn <andrew@lunn.ch>
    Link: https://patch.msgid.link/20241002161807.440378-1-inguin@gmx.de
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Signed-off-by: Izabela Bakollari <ibakolla@redhat.com>

Author: Izabela Bakollari

drivers/net/phy/dp83869.c

@@ -645,7 +645,6 @@ static int dp83869_configure_fiber(struct phy_device *phydev,
 		     phydev->supported);
 
 	linkmode_set_bit(ETHTOOL_LINK_MODE_FIBRE_BIT, phydev->supported);
-	linkmode_set_bit(ADVERTISED_FIBRE, phydev->advertising);
 
 	if (dp83869->mode == DP83869_RGMII_1000_BASE) {
 		linkmode_set_bit(ETHTOOL_LINK_MODE_1000baseX_Full_BIT,