Skip to content

Commit 3d091c8

Browse files
committed
ice: read TSPLL registers again before reporting status
JIRA: https://issues.redhat.com/browse/RHEL-104246 Upstream commit(s): commit 38f742d Author: Jacob Keller <jacob.e.keller@intel.com> Date: Mon Jun 23 17:29:58 2025 -0700 ice: read TSPLL registers again before reporting status After programming the TSPLL, re-read the registers before reporting status. This ensures the debug log message will show what was actually programmed, rather than relying on a cached value. Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com> Signed-off-by: Petr Oros <poros@redhat.com>
1 parent 29adc84 commit 3d091c8

File tree

1 file changed

+18
-4
lines changed

1 file changed

+18
-4
lines changed

drivers/net/ethernet/intel/ice/ice_tspll.c

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -239,8 +239,15 @@ static int ice_tspll_cfg_e82x(struct ice_hw *hw, enum ice_tspll_freq clk_freq,
239239
return -EBUSY;
240240
}
241241

242-
ice_tspll_log_cfg(hw, dw24.ts_pll_enable, clk_src, clk_freq, true,
243-
true);
242+
err = ice_read_cgu_reg(hw, ICE_CGU_R9, &dw9.val);
243+
if (err)
244+
return err;
245+
err = ice_read_cgu_reg(hw, ICE_CGU_R24, &dw24.val);
246+
if (err)
247+
return err;
248+
249+
ice_tspll_log_cfg(hw, dw24.ts_pll_enable, dw24.time_ref_sel,
250+
dw9.time_ref_freq_sel, true, false);
244251

245252
return 0;
246253
}
@@ -433,8 +440,15 @@ static int ice_tspll_cfg_e825c(struct ice_hw *hw, enum ice_tspll_freq clk_freq,
433440
return -EBUSY;
434441
}
435442

436-
ice_tspll_log_cfg(hw, dw23.ts_pll_enable, clk_src, clk_freq, true,
437-
true);
443+
err = ice_read_cgu_reg(hw, ICE_CGU_R9, &dw9.val);
444+
if (err)
445+
return err;
446+
err = ice_read_cgu_reg(hw, ICE_CGU_R23, &dw23.val);
447+
if (err)
448+
return err;
449+
450+
ice_tspll_log_cfg(hw, dw23.ts_pll_enable, dw23.time_ref_sel,
451+
dw9.time_ref_freq_sel, true, true);
438452

439453
return 0;
440454
}

0 commit comments

Comments
 (0)