Skip to content

Commit 21ab517

Browse files
Christoph Hellwigcmaiolino
authored andcommitted
xfs: fix zone selection in xfs_select_open_zone_mru
xfs_select_open_zone_mru needs to pass XFS_ZONE_ALLOC_OK to xfs_try_use_zone because we only want to tightly pack into zones of the same or a compatible temperature instead of any available zone. This got broken in commit 0301dae ("xfs: refactor hint based zone allocation"), which failed to update this particular caller when switching to an enum. xfs/638 sometimes, but not reliably fails due to this change. Fixes: 0301dae ("xfs: refactor hint based zone allocation") Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Hans Holmberg <hans.holmberg@wdc.com> Signed-off-by: Carlos Maiolino <cem@kernel.org>
1 parent f5714a3 commit 21ab517

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/xfs/xfs_zone_alloc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -615,7 +615,7 @@ xfs_select_open_zone_mru(
615615
lockdep_assert_held(&zi->zi_open_zones_lock);
616616

617617
list_for_each_entry_reverse(oz, &zi->zi_open_zones, oz_entry)
618-
if (xfs_try_use_zone(zi, file_hint, oz, false))
618+
if (xfs_try_use_zone(zi, file_hint, oz, XFS_ZONE_ALLOC_OK))
619619
return oz;
620620

621621
cond_resched_lock(&zi->zi_open_zones_lock);

0 commit comments

Comments
 (0)