xfs: fix a rtgroup leak when xfs_init_zone fails

Christoph Hellwig · cmaiolino · commit f5714a3c1a56 · 2025-11-05T16:53:49.000+01:00
Drop the rtgrop reference when xfs_init_zone fails for a conventional device. Fixes: 4e4d520 ("xfs: add the zoned space allocator") Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Hans Holmberg <hans.holmberg@wdc.com> Signed-off-by: Carlos Maiolino <cem@kernel.org>
diff --git a/fs/xfs/xfs_zone_alloc.c b/fs/xfs/xfs_zone_alloc.c
@@ -1249,8 +1249,10 @@ xfs_mount_zones(
 
 		while ((rtg = xfs_rtgroup_next(mp, rtg))) {
 			error = xfs_init_zone(&iz, rtg, NULL);
-			if (error)
+			if (error) {
+				xfs_rtgroup_rele(rtg);
 				goto out_free_zone_info;
+			}
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1249,8 +1249,10 @@ xfs_mount_zones(`
`1249`	`1249`
`1250`	`1250`	`while ((rtg = xfs_rtgroup_next(mp, rtg))) {`
`1251`	`1251`	`error = xfs_init_zone(&iz, rtg, NULL);`
`1252`		`- if (error)`
	`1252`	`+ if (error) {`
	`1253`	`+ xfs_rtgroup_rele(rtg);`
`1253`	`1254`	`goto out_free_zone_info;`
	`1255`	`+ }`
`1254`	`1256`	`}`
`1255`	`1257`	`}`
`1256`	`1258`