Skip to content

Commit 1aa3169

Browse files
KanjiMonstergregkh
authored andcommitted
net: dsa: b53: allow RGMII for bcm63xx RGMII ports
[ Upstream commit 5ea0d42 ] Add RGMII to supported interfaces for BCM63xx RGMII ports so they can be actually used in RGMII mode. Without this, phylink will fail to configure them: [ 3.580000] b53-switch 10700000.switch GbE3 (uninitialized): validation of rgmii with support 0000000,00000000,00000000,000062ff and advertisement 0000000,00000000,00000000,000062ff failed: -EINVAL [ 3.600000] b53-switch 10700000.switch GbE3 (uninitialized): failed to connect to PHY: -EINVAL [ 3.610000] b53-switch 10700000.switch GbE3 (uninitialized): error -22 setting up PHY for tree 0, switch 0, port 4 Fixes: ce3bf94 ("net: dsa: b53: add support for BCM63xx RGMIIs") Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com> Link: https://patch.msgid.link/20250602193953.1010487-5-jonas.gorski@gmail.com Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 6d1c93a commit 1aa3169

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/net/dsa/b53/b53_common.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1441,6 +1441,10 @@ static void b53_phylink_get_caps(struct dsa_switch *ds, int port,
14411441
__set_bit(PHY_INTERFACE_MODE_MII, config->supported_interfaces);
14421442
__set_bit(PHY_INTERFACE_MODE_REVMII, config->supported_interfaces);
14431443

1444+
/* BCM63xx RGMII ports support RGMII */
1445+
if (is63xx(dev) && in_range(port, B53_63XX_RGMII0, 4))
1446+
phy_interface_set_rgmii(config->supported_interfaces);
1447+
14441448
config->mac_capabilities = MAC_ASYM_PAUSE | MAC_SYM_PAUSE |
14451449
MAC_10 | MAC_100;
14461450

0 commit comments

Comments
 (0)