Skip to content

Commit 6d1c93a

Browse files
KanjiMonstergregkh
authored andcommitted
net: dsa: b53: do not enable RGMII delay on bcm63xx
[ Upstream commit 4af5235 ] bcm63xx's RGMII ports are always in MAC mode, never in PHY mode, so we shouldn't enable any delays and let the PHY handle any delays as necessary. This fixes using RGMII ports with normal PHYs like BCM54612E, which will handle the delay in the PHY. Fixes: ce3bf94 ("net: dsa: b53: add support for BCM63xx RGMIIs") Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Link: https://patch.msgid.link/20250602193953.1010487-3-jonas.gorski@gmail.com Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 6c2e062 commit 6d1c93a

File tree

1 file changed

+1
-18
lines changed

1 file changed

+1
-18
lines changed

drivers/net/dsa/b53/b53_common.c

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1326,24 +1326,7 @@ static void b53_adjust_63xx_rgmii(struct dsa_switch *ds, int port,
13261326
off = B53_RGMII_CTRL_P(port);
13271327

13281328
b53_read8(dev, B53_CTRL_PAGE, off, &rgmii_ctrl);
1329-
1330-
switch (interface) {
1331-
case PHY_INTERFACE_MODE_RGMII_ID:
1332-
rgmii_ctrl |= (RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC);
1333-
break;
1334-
case PHY_INTERFACE_MODE_RGMII_RXID:
1335-
rgmii_ctrl &= ~(RGMII_CTRL_DLL_TXC);
1336-
rgmii_ctrl |= RGMII_CTRL_DLL_RXC;
1337-
break;
1338-
case PHY_INTERFACE_MODE_RGMII_TXID:
1339-
rgmii_ctrl &= ~(RGMII_CTRL_DLL_RXC);
1340-
rgmii_ctrl |= RGMII_CTRL_DLL_TXC;
1341-
break;
1342-
case PHY_INTERFACE_MODE_RGMII:
1343-
default:
1344-
rgmii_ctrl &= ~(RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC);
1345-
break;
1346-
}
1329+
rgmii_ctrl &= ~(RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC);
13471330

13481331
if (port != dev->imp_port) {
13491332
if (is63268(dev))

0 commit comments

Comments
 (0)