Skip to content

[RI] Change the fuzz factor to 2 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: mainline
Choose a base branch
from
Open

[RI] Change the fuzz factor to 2 #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion run_interdiff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def run_interdiff(repo, backport_sha, upstream_sha, interdiff_path):
up_path = up.name

Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The change from --fuzzy=3 to --fuzzy relies on the default fuzz factor being 2. Consider adding a comment explaining this default behavior for future maintainability, e.g.:

# Use default fuzz factor of 2 for better patch application results
[interdiff_path, "--fuzzy", bp_path, up_path]

This would make the intent clearer and document the assumed default value.

Suggested change
# Use default fuzz factor of 2 for better patch application results

Copilot uses AI. Check for mistakes.
interdiff_result = subprocess.run(
[interdiff_path, "--fuzzy=3", bp_path, up_path], text=True, capture_output=True, check=False
[interdiff_path, "--fuzzy", bp_path, up_path], text=True, capture_output=True, check=False
)

# Check for interdiff errors (non-zero return code other than 1)
Expand Down
Loading